[PATCH] Indentation error for Python module seobject (fix typo)

[PATCH] Indentation error for Python module seobject (fix typo)

[Guido Trentalancia]

Hello.

I get an IndentationError from Python when running code which imports
seobject.py (line 182).

The following simple patch fixes the problem for current git:

--- selinux-22092011/policycoreutils/semanage/seobject.py	2011-09-17 07:03:41.147162393 +0200
+++ selinux-22092011-fix-indentation-error-in-seobject-python/policycoreutils/semanage/seobject.py	2011-09-22 22:19:19.036640459 +0200
@@ -182,7 +182,7 @@ class semanageRecords:
 
                if not semanageRecords.transaction and store != "":
                       semanage_select_store(handle, store, SEMANAGE_CON_DIRECT);
-                     semanageRecords.store = store
+                      semanageRecords.store = store
 
                if not semanage_is_managed(handle):
                       semanage_handle_destroy(handle)

Thanks.

Guido


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

Re: [PATCH] Indentation error for Python module seobject (fix typo)

[Eric Paris]

It's fixed in a patch on the queue branch titled:

    policycoreutils: semanage: FIXME whitespace changes in seobject

Since I believe that is the only line of that patch which actually
fixes a bug, I'll look at applying your patch to head soon.

-Eric

On Thu, Sep 22, 2011 at 4:26 PM, Guido Trentalancia
<guido@trentalancia.com> wrote:
> Hello.
>
> I get an IndentationError from Python when running code which imports
> seobject.py (line 182).
>
> The following simple patch fixes the problem for current git:
>
> --- selinux-22092011/policycoreutils/semanage/seobject.py       2011-09-17 07:03:41.147162393 +0200
> +++ selinux-22092011-fix-indentation-error-in-seobject-python/policycoreutils/semanage/seobject.py      2011-09-22 22:19:19.036640459 +0200
> @@ -182,7 +182,7 @@ class semanageRecords:
>
>                if not semanageRecords.transaction and store != "":
>                       semanage_select_store(handle, store, SEMANAGE_CON_DIRECT);
> -                     semanageRecords.store = store
> +                      semanageRecords.store = store
>
>                if not semanage_is_managed(handle):
>                       semanage_handle_destroy(handle)
>
> Thanks.
>
> Guido
>
>
> --
> This message was distributed to subscribers of the selinux mailing list.
> If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
> the words "unsubscribe selinux" without quotes as the message.
>


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

Re: [PATCH] Indentation error for Python module seobject (fix typo)

[Guido Trentalancia]

On Thu, 2011-09-22 at 16:45 -0400, Eric Paris wrote:
> It's fixed in a patch on the queue branch titled:
> 
>     policycoreutils: semanage: FIXME whitespace changes in seobject
> 
> Since I believe that is the only line of that patch which actually
> fixes a bug, I'll look at applying your patch to head soon.

Yes, please. It breaks execution otherwise.

> -Eric

Thanks. Guido

> On Thu, Sep 22, 2011 at 4:26 PM, Guido Trentalancia
> <guido@trentalancia.com> wrote:
> > Hello.
> >
> > I get an IndentationError from Python when running code which imports
> > seobject.py (line 182).
> >
> > The following simple patch fixes the problem for current git:
> >
> > --- selinux-22092011/policycoreutils/semanage/seobject.py       2011-09-17 07:03:41.147162393 +0200
> > +++ selinux-22092011-fix-indentation-error-in-seobject-python/policycoreutils/semanage/seobject.py      2011-09-22 22:19:19.036640459 +0200
> > @@ -182,7 +182,7 @@ class semanageRecords:
> >
> >                if not semanageRecords.transaction and store != "":
> >                       semanage_select_store(handle, store, SEMANAGE_CON_DIRECT);
> > -                     semanageRecords.store = store
> > +                      semanageRecords.store = store
> >
> >                if not semanage_is_managed(handle):
> >                       semanage_handle_destroy(handle)
> >
> > Thanks.
> >
> > Guido
> >
> >
> > --
> > This message was distributed to subscribers of the selinux mailing list.
> > If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
> > the words "unsubscribe selinux" without quotes as the message.
> >
> 



--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

Re: [PATCH] Indentation error for Python module seobject (fix typo)

[Ethan Heidrick]

[-- Attachment #1: Type: text/plain, Size: 2218 bytes --]

Hello,

wasn't the semanage function fixed without the creating a object directory
earlier?  If i remember but the patch was directed at not adding a new
line.  I may be wrong.

thanks.

On Thu, Sep 22, 2011 at 1:47 PM, Guido Trentalancia
<guido@trentalancia.com>wrote:

> On Thu, 2011-09-22 at 16:45 -0400, Eric Paris wrote:
> > It's fixed in a patch on the queue branch titled:
> >
> >     policycoreutils: semanage: FIXME whitespace changes in seobject
> >
> > Since I believe that is the only line of that patch which actually
> > fixes a bug, I'll look at applying your patch to head soon.
>
> Yes, please. It breaks execution otherwise.
>
> > -Eric
>
> Thanks. Guido
>
> > On Thu, Sep 22, 2011 at 4:26 PM, Guido Trentalancia
> > <guido@trentalancia.com> wrote:
> > > Hello.
> > >
> > > I get an IndentationError from Python when running code which imports
> > > seobject.py (line 182).
> > >
> > > The following simple patch fixes the problem for current git:
> > >
> > > --- selinux-22092011/policycoreutils/semanage/seobject.py
> 2011-09-17 07:03:41.147162393 +0200
> > > +++
> selinux-22092011-fix-indentation-error-in-seobject-python/policycoreutils/semanage/seobject.py
>      2011-09-22 22:19:19.036640459 +0200
> > > @@ -182,7 +182,7 @@ class semanageRecords:
> > >
> > >                if not semanageRecords.transaction and store != "":
> > >                       semanage_select_store(handle, store,
> SEMANAGE_CON_DIRECT);
> > > -                     semanageRecords.store = store
> > > +                      semanageRecords.store = store
> > >
> > >                if not semanage_is_managed(handle):
> > >                       semanage_handle_destroy(handle)
> > >
> > > Thanks.
> > >
> > > Guido
> > >
> > >
> > > --
> > > This message was distributed to subscribers of the selinux mailing
> list.
> > > If you no longer wish to subscribe, send mail to
> majordomo@tycho.nsa.gov with
> > > the words "unsubscribe selinux" without quotes as the message.
> > >
> >
>
>
>
> --
> This message was distributed to subscribers of the selinux mailing list.
> If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.govwith
> the words "unsubscribe selinux" without quotes as the message.
>

[-- Attachment #2: Type: text/html, Size: 3132 bytes --]