From: Alex Elder <aelder@sgi.com>
To: Lukas Czerner <lczerner@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/2 v2][xfstests] fstrim: Use strtoull instead of strtoul
Date: Thu, 22 Sep 2011 15:59:14 -0500 [thread overview]
Message-ID: <1316725154.2009.80.camel@doink> (raw)
In-Reply-To: <1315410523-23925-2-git-send-email-lczerner@redhat.com>
On Wed, 2011-09-07 at 17:48 +0200, Lukas Czerner wrote:
> When we are parsing input arguments we should really use stroull to get
> unsigned long long numbers, since this is what we can specify on the
> command line. With this fix it should parse long numbers on the 32 bit
> architecture correctly.
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
This looks good, and it can be applied independent of the
first patch in this series. (And at this point I plan to
commit this first rather than wait.)
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-09-22 20:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-07 15:48 [PATCH 1/2 v2][xfstests] Add test 257: Check proper FITRIM argument handling Lukas Czerner
2011-09-07 15:48 ` [PATCH 2/2 v2][xfstests] fstrim: Use strtoull instead of strtoul Lukas Czerner
2011-09-22 20:59 ` Alex Elder [this message]
2011-09-22 9:37 ` [PATCH 1/2 v2][xfstests] Add test 257: Check proper FITRIM argument handling Lukas Czerner
2011-09-22 16:36 ` Christoph Hellwig
2011-09-22 20:52 ` Alex Elder
2011-09-23 7:38 ` Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316725154.2009.80.camel@doink \
--to=aelder@sgi.com \
--cc=lczerner@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.