From: Christoph Hellwig <hch@infradead.org>
To: Lukas Czerner <lczerner@redhat.com>
Cc: xfs@oss.sgi.com, aelder@sgi.com
Subject: Re: [PATCH 1/2 v2][xfstests] Add test 257: Check proper FITRIM argument handling
Date: Thu, 22 Sep 2011 12:36:55 -0400 [thread overview]
Message-ID: <20110922163655.GA627@infradead.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1109221136590.4968@dhcp-27-109.brq.redhat.com>
On Thu, Sep 22, 2011 at 11:37:32AM +0200, Lukas Czerner wrote:
> > + # Btrfs is special and this test does not apply to it
> > + if [ $bytes -le $(($fsize*512)) ] && [ $FSTYP != "btrfs" ]; then
> > + status=1
> > + echo "It seems that fs logic handling len argument overflows"
> > + fi
>
Care to explain why btrfs is "special"?
Also I can't parse the sentence above in the echo line.
>
> > + export MKFS_OPTIONS=$backup_mkfs_options
why backup?
Otherwise this looks reasonable to me?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-09-22 16:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-07 15:48 [PATCH 1/2 v2][xfstests] Add test 257: Check proper FITRIM argument handling Lukas Czerner
2011-09-07 15:48 ` [PATCH 2/2 v2][xfstests] fstrim: Use strtoull instead of strtoul Lukas Czerner
2011-09-22 20:59 ` Alex Elder
2011-09-22 9:37 ` [PATCH 1/2 v2][xfstests] Add test 257: Check proper FITRIM argument handling Lukas Czerner
2011-09-22 16:36 ` Christoph Hellwig [this message]
2011-09-22 20:52 ` Alex Elder
2011-09-23 7:38 ` Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110922163655.GA627@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=lczerner@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.