All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: David Rientjes <rientjes@google.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] show page size in /proc/$pid/numa_maps
Date: Fri, 23 Sep 2011 08:54:28 -0700	[thread overview]
Message-ID: <1316793268.16137.481.camel@nimitz> (raw)
In-Reply-To: <alpine.DEB.2.00.1109221339520.31548@chino.kir.corp.google.com>

On Thu, 2011-09-22 at 13:43 -0700, David Rientjes wrote:
> Why not just add a pagesize={4K,2M,1G,...} field for every output? 

I think it's a bit misleading.  With THP at least we have 2M pages in
the MMU, but we're reporting in 4k units.

I certainly considered doing just what you're suggesting, though.  It's
definitely not a bad idea.  Certainly much more clear.

-- Dave


WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: David Rientjes <rientjes@google.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] show page size in /proc/$pid/numa_maps
Date: Fri, 23 Sep 2011 08:54:28 -0700	[thread overview]
Message-ID: <1316793268.16137.481.camel@nimitz> (raw)
In-Reply-To: <alpine.DEB.2.00.1109221339520.31548@chino.kir.corp.google.com>

On Thu, 2011-09-22 at 13:43 -0700, David Rientjes wrote:
> Why not just add a pagesize={4K,2M,1G,...} field for every output? 

I think it's a bit misleading.  With THP at least we have 2M pages in
the MMU, but we're reporting in 4k units.

I certainly considered doing just what you're suggesting, though.  It's
definitely not a bad idea.  Certainly much more clear.

-- Dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-09-23 15:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-21 22:13 [RFC][PATCH] show page size in /proc/$pid/numa_maps Dave Hansen
2011-09-21 22:13 ` Dave Hansen
2011-09-22 20:43 ` David Rientjes
2011-09-22 20:43   ` David Rientjes
2011-09-23 15:54   ` Dave Hansen [this message]
2011-09-23 15:54     ` Dave Hansen
2011-09-23 20:04     ` David Rientjes
2011-09-23 20:04       ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1316793268.16137.481.camel@nimitz \
    --to=dave@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.