[PATCH 0/3] Hob bug fixes

[PATCH 0/3] Hob bug fixes

[Joshua Lock]

This series includes a few fixes found whilst debugging and fixing
Yocto bug #1521
http://bugzilla.yoctoproject.org/show_bug.cgi?id=1521

Richard, please consider these for Yocto 1.1

Regards,
Joshua

The following changes since commit 623e9c7f7a9cf12b8c81c26cc608990682a601dd:

  Fix mercurial fetcher in fetch2 (2011-09-21 14:07:14 +0100)

are available in the git repository at:
  git://github.com/incandescant/bitbake hob
  https://github.com/incandescant/bitbake/tree/hob

Joshua Lock (3):
  ui/crumbs/hobeventhandler: move remaining getVariable calls to init
  ui/crumbs/hobeventhandler: fix variable name typo
  hob: fix building with current selections after reparse

 lib/bb/ui/crumbs/hobeventhandler.py |   11 ++++++-----
 lib/bb/ui/hob.py                    |    2 --
 2 files changed, 6 insertions(+), 7 deletions(-)

-- 
1.7.6.2

[PATCH 1/3] ui/crumbs/hobeventhandler: move remaining getVariable calls to init

[Joshua Lock]

Instead of calling getVariable commands each time the BBPATH and BBFILES
entries need testing cache the results as a member variable at object
instantiation.

Fixes [YOCTO #1521]

Signed-off-by: Joshua Lock <josh@linux.intel.com>
---
 lib/bb/ui/crumbs/hobeventhandler.py |    9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/lib/bb/ui/crumbs/hobeventhandler.py b/lib/bb/ui/crumbs/hobeventhandler.py
index 30504e1..44dc4ac 100644
--- a/lib/bb/ui/crumbs/hobeventhandler.py
+++ b/lib/bb/ui/crumbs/hobeventhandler.py
@@ -88,6 +88,8 @@ class HobHandler(gobject.GObject):
         deploy_dir = self.server.runCommand(["getVariable", "DEPLOY_DIR"])
         self.image_out_dir = os.path.join(deploy_dir, "images")
         self.image_output_types = self.server.runCommand(["getVariable", "IMAGE_FSTYPES"]).split(" ")
+        self.bbpath = self.server.runCommand(["getVariable", "BBPATH"])
+        self.bbfiles = self.server.runCommand(["getVariable", "BBFILES"])
 
     def run_next_command(self):
         if self.current_command and not self.generating:
@@ -263,8 +265,7 @@ class HobHandler(gobject.GObject):
         self.build_queue = targets
 
         if not self.bbpath_ok:
-            bbpath = self.server.runCommand(["getVariable", "BBPATH"])
-            if self.image_dir in bbpath.split(":"):
+            if self.image_dir in self.bbpath.split(":"):
                 self.bbpath_ok = True
             else:
                 nbbp = self.image_dir
@@ -272,8 +273,8 @@ class HobHandler(gobject.GObject):
         if not self.bbfiles_ok:
             import re
             pattern = "%s/\*.bb" % self.image_dir
-            bbfiles = self.server.runCommand(["getVariable", "BBFILES"]).split(" ")
-            for files in bbfiles:
+
+            for files in self.bbfiles.split(" "):
                 if re.match(pattern, files):
                     self.bbfiles_ok = True
 
-- 
1.7.6.2

[PATCH 2/3] ui/crumbs/hobeventhandler: fix variable name typo

[Joshua Lock]

Signed-off-by: Joshua Lock <josh@linux.intel.com>
---
 lib/bb/ui/crumbs/hobeventhandler.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/bb/ui/crumbs/hobeventhandler.py b/lib/bb/ui/crumbs/hobeventhandler.py
index 44dc4ac..ddab987 100644
--- a/lib/bb/ui/crumbs/hobeventhandler.py
+++ b/lib/bb/ui/crumbs/hobeventhandler.py
@@ -328,7 +328,7 @@ class HobHandler(gobject.GObject):
         return self.image_output_types
 
     def get_image_deploy_dir(self):
-        return self.img_out_dir
+        return self.image_out_dir
 
     def make_temp_dir(self):
         bb.utils.mkdirhier(self.image_dir)
-- 
1.7.6.2

[PATCH 3/3] hob: fix building with current selections after reparse

[Joshua Lock]

After the reparse we were setting the model to reflect the values before
the reparse was triggered but clearing the internal variables used to test
whether these values are set, leading to the UI erroneously reporting that
selections had not been made.

Signed-off-by: Joshua Lock <josh@linux.intel.com>
---
 lib/bb/ui/hob.py |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/lib/bb/ui/hob.py b/lib/bb/ui/hob.py
index e696314..c016e44 100644
--- a/lib/bb/ui/hob.py
+++ b/lib/bb/ui/hob.py
@@ -304,13 +304,11 @@ class MainWindow (gtk.Window):
                 self.image_combo.disconnect(self.image_combo_id)
                 self.image_combo_id = None
             self.model.set_selected_image(self.selected_image)
-            self.selected_image = None
             if not self.image_combo_id:
                 self.image_combo_id = self.image_combo.connect("changed", self.image_changed_cb)
 
         if self.selected_packages:
             self.model.set_selected_packages(self.selected_packages)
-            self.selected_packages = None
 
     def reset_clicked_cb(self, button):
         lbl = "<b>Reset your selections?</b>\n\nAny new changes you have made will be lost"
-- 
1.7.6.2

Re: [PATCH 0/3] Hob bug fixes

[Richard Purdie]

On Fri, 2011-09-23 at 13:34 -0700, Joshua Lock wrote:
> This series includes a few fixes found whilst debugging and fixing
> Yocto bug #1521
> http://bugzilla.yoctoproject.org/show_bug.cgi?id=1521
> 
> Richard, please consider these for Yocto 1.1
> 
> Regards,
> Joshua
> 
> The following changes since commit 623e9c7f7a9cf12b8c81c26cc608990682a601dd:
> 
>   Fix mercurial fetcher in fetch2 (2011-09-21 14:07:14 +0100)
> 
> are available in the git repository at:
>   git://github.com/incandescant/bitbake hob
>   https://github.com/incandescant/bitbake/tree/hob
> 
> Joshua Lock (3):
>   ui/crumbs/hobeventhandler: move remaining getVariable calls to init
>   ui/crumbs/hobeventhandler: fix variable name typo
>   hob: fix building with current selections after reparse

Merged to master, thanks.

Richard

[PATCH 0/3] Hob: bug fixes

[Liming An]

The following changes since commit de4cdfd6bc1280ac7ac0559b87734d26294ef773:

  documentation/kernel-manual/kernel-how-to.xml: Updated to kernel 3.4 (2012-05-31 21:16:55 +0100)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib limx/hob-bug-fixes-continue
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=limx/hob-bug-fixes-continue

Liming An (3):
  Hob: clear the repeated function get_kernel_file_name
  Hob: fix entry of recipe page can't be edited in case after clicked
    clear button
  Hob: fixed a definition not match issue when click choose directflb
    in package page

 bitbake/lib/bb/ui/crumbs/builder.py              |    5 +++--
 bitbake/lib/bb/ui/crumbs/hobwidget.py            |   10 ++--------
 bitbake/lib/bb/ui/crumbs/imagedetailspage.py     |   19 +------------------
 bitbake/lib/bb/ui/crumbs/packageselectionpage.py |    2 +-
 4 files changed, 7 insertions(+), 29 deletions(-)

-- 
1.7.5.4

Re: [PATCH 0/3] Hob: bug fixes

[Richard Purdie]

On Fri, 2012-06-01 at 18:36 +0800, Liming An wrote:
> The following changes since commit de4cdfd6bc1280ac7ac0559b87734d26294ef773:
> 
>   documentation/kernel-manual/kernel-how-to.xml: Updated to kernel 3.4 (2012-05-31 21:16:55 +0100)
> 
> are available in the git repository at:
>   git://git.pokylinux.org/poky-contrib limx/hob-bug-fixes-continue
>   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=limx/hob-bug-fixes-continue
> 
> Liming An (3):
>   Hob: clear the repeated function get_kernel_file_name
>   Hob: fix entry of recipe page can't be edited in case after clicked
>     clear button
>   Hob: fixed a definition not match issue when click choose directflb
>     in package page

Merged to master, thanks.

Richard