From: "J. R. Okajima" <hooanon05g@gmail.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Jeff Layton <jlayton@primarydata.com>
Subject: Re: [PATCH] dcache: return -ESTALE not -EBUSY on distributed fs race
Date: Fri, 19 Dec 2014 01:27:14 +0900 [thread overview]
Message-ID: <13170.1418920034@jrobl> (raw)
In-Reply-To: <20141218155838.GD18179@fieldses.org>
"J. Bruce Fields":
> Why do you think -EBUSY's the right error in the local filesystem case?
This busy_or_stale() is another bandaid, based upon your patch, EBUSY
--> ESTALE.
Because the msg string of ESTALE is "Stale NFS file handle" on many
systems, I don't think it a good idea to return it for local fs. If you
think EIO is better than EBUSY you can change it to eio_or_stale(). If
you think it is surely not happen on every local fs, then this inline
function is not necessary.
J. R. Okajima
WARNING: multiple messages have this Message-ID (diff)
From: "J. R. Okajima" <hooanon05g-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "J. Bruce Fields" <bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
Cc: Al Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jeff Layton <jlayton-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>
Subject: Re: [PATCH] dcache: return -ESTALE not -EBUSY on distributed fs race
Date: Fri, 19 Dec 2014 01:27:14 +0900 [thread overview]
Message-ID: <13170.1418920034@jrobl> (raw)
In-Reply-To: <20141218155838.GD18179-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
"J. Bruce Fields":
> Why do you think -EBUSY's the right error in the local filesystem case?
This busy_or_stale() is another bandaid, based upon your patch, EBUSY
--> ESTALE.
Because the msg string of ESTALE is "Stale NFS file handle" on many
systems, I don't think it a good idea to return it for local fs. If you
think EIO is better than EBUSY you can change it to eio_or_stale(). If
you think it is surely not happen on every local fs, then this inline
function is not necessary.
J. R. Okajima
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-12-18 16:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 19:59 [PATCH] dcache: return -ESTALE not -EBUSY on distributed fs race J. Bruce Fields
2014-12-17 20:01 ` J. Bruce Fields
2014-12-17 20:01 ` J. Bruce Fields
2014-12-18 15:50 ` J. R. Okajima
2014-12-18 15:58 ` J. Bruce Fields
2014-12-18 15:58 ` J. Bruce Fields
2014-12-18 16:27 ` J. R. Okajima [this message]
2014-12-18 16:27 ` J. R. Okajima
2014-12-18 17:32 ` Jeff Layton
2014-12-18 23:15 ` Dave Chinner
2014-12-18 23:15 ` Dave Chinner
2014-12-19 2:46 ` J. R. Okajima
2014-12-19 11:09 ` Jeff Layton
2014-12-19 11:09 ` Jeff Layton
2014-12-22 9:53 ` J. R. Okajima
-- strict thread matches above, loose matches on Subject: below --
2015-02-10 15:55 J. Bruce Fields
2015-02-10 15:55 ` J. Bruce Fields
2015-02-18 15:03 ` J. Bruce Fields
2015-02-24 21:22 ` J. Bruce Fields
2015-02-24 21:22 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13170.1418920034@jrobl \
--to=hooanon05g@gmail.com \
--cc=bfields@fieldses.org \
--cc=jlayton@primarydata.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.