From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Eric Sandeen <sandeen@redhat.com>,
Boris Ranto <branto@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: xfstests 258: Test xfs fs creation with fs size close to 4 TB
Date: Mon, 26 Sep 2011 07:18:46 -0500 [thread overview]
Message-ID: <1317039526.3030.16.camel@doink> (raw)
In-Reply-To: <20110926114458.GA1176@infradead.org>
On Mon, 2011-09-26 at 07:44 -0400, Christoph Hellwig wrote:
> This one actually fails for me in a 32-bit userspace VM:
This is my fault, and you busted me doing something I
should not have.
It doesn't matter in this case, but there is a window in
which "testfile" is undefined but gets referenced in
_cleanup() (which could get called due to interrupt).
I "trivially" moved the definition to fix that oversight
and as a result broke the test.
I won't do that any more without taking proper credit
when I commit.
Sorry Boris (and all).
Your fix looks fine, Christoph.
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-09-26 12:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 13:52 xfstests 258: Test xfs fs creation with fs size close to 4 TB Boris Ranto
2011-09-21 16:54 ` Alex Elder
2011-09-21 19:06 ` Arkadiusz Miśkiewicz
2011-09-22 8:30 ` Boris Ranto
2011-09-22 16:30 ` Alex Elder
2011-09-26 11:44 ` Christoph Hellwig
2011-09-26 12:18 ` Alex Elder [this message]
2011-09-26 15:59 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317039526.3030.16.camel@doink \
--to=aelder@sgi.com \
--cc=branto@redhat.com \
--cc=hch@infradead.org \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.