All of lore.kernel.org
 help / color / mirror / Atom feed
From: Axel Lin <axel.lin@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Liam Girdwood <lrg@ti.com>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	alsa-devel@alsa-project.org,
	Peter Hsiang <peter.hsiang@maxim-ic.com>,
	Jesse Marroquin <jesse.marroquin@maxim-ic.com>
Subject: [PATCH 5/6] ASoC: Remove unused "control_data" field of struct max98088_priv
Date: Wed, 28 Sep 2011 10:12:48 +0800	[thread overview]
Message-ID: <1317175968.14102.7.camel@phoenix> (raw)
In-Reply-To: <1317175218.14102.1.camel@phoenix>

The control_data field is used to initialize the codec's control_data field,
but since this is also done by the snd-soc-cache core, the redundant
assignment can be removed and the field can be dropped.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 sound/soc/codecs/max98088.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/max98088.c b/sound/soc/codecs/max98088.c
index ac65a2d..587043b 100644
--- a/sound/soc/codecs/max98088.c
+++ b/sound/soc/codecs/max98088.c
@@ -40,7 +40,6 @@ struct max98088_cdata {
 
 struct max98088_priv {
        enum max98088_type devtype;
-       void *control_data;
        struct max98088_pdata *pdata;
        unsigned int sysclk;
        struct max98088_cdata dai[2];
@@ -2066,7 +2065,6 @@ static int max98088_i2c_probe(struct i2c_client *i2c,
        max98088->devtype = id->driver_data;
 
        i2c_set_clientdata(i2c, max98088);
-       max98088->control_data = i2c;
        max98088->pdata = i2c->dev.platform_data;
 
        ret = snd_soc_register_codec(&i2c->dev,
-- 
1.7.4.1

  parent reply	other threads:[~2011-09-28  2:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-28  2:00 [PATCH 1/6] ASoC: Remove unused "control_data" field of struct ak4671_priv Axel Lin
2011-09-28  2:01 ` [PATCH 2/6] ASoC: Remove unused "control_data" field of struct alc5623_priv Axel Lin
2011-09-28  2:10 ` [PATCH 3/6] ASoC: Remove unused "control_data" field of struct cs4270_private Axel Lin
2011-09-28 19:30   ` Timur Tabi
2011-09-28 19:30     ` Timur Tabi
2011-09-29  9:48     ` Mark Brown
2011-09-28  2:11 ` [PATCH 4/6] ASoC: Remove unused "control_data" field of struct cs42l51_private Axel Lin
2011-09-28  2:12 ` Axel Lin [this message]
2011-09-28  2:14 ` [PATCH 6/6] ASoC: Remove unused "control_data" field of struct max98095_priv Axel Lin
2011-09-28 12:20 ` [PATCH 1/6] ASoC: Remove unused "control_data" field of struct ak4671_priv Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1317175968.14102.7.camel@phoenix \
    --to=axel.lin@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=jesse.marroquin@maxim-ic.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=peter.hsiang@maxim-ic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.