From: Timur Tabi <timur@freescale.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lrg@ti.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 3/6] ASoC: Remove unused "control_data" field of struct cs4270_private
Date: Wed, 28 Sep 2011 14:30:53 -0500 [thread overview]
Message-ID: <4E8375ED.1060209@freescale.com> (raw)
In-Reply-To: <1317175838.14102.4.camel@phoenix>
Axel Lin wrote:
> The control_data field is used to initialize the codec's control_data field,
> but since this is also done by the snd-soc-cache core, the redundant
> assignment can be removed and the field can be dropped.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
Acked-by: Timur Tabi <timur@freescale.com>
Although Mark, it would have been nice if you had given me a chance to test this
change before applying the patch.
--
Timur Tabi
Linux kernel developer at Freescale
WARNING: multiple messages have this Message-ID (diff)
From: Timur Tabi <timur@freescale.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: <linux-kernel@vger.kernel.org>, Liam Girdwood <lrg@ti.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
<alsa-devel@alsa-project.org>
Subject: Re: [PATCH 3/6] ASoC: Remove unused "control_data" field of struct cs4270_private
Date: Wed, 28 Sep 2011 14:30:53 -0500 [thread overview]
Message-ID: <4E8375ED.1060209@freescale.com> (raw)
In-Reply-To: <1317175838.14102.4.camel@phoenix>
Axel Lin wrote:
> The control_data field is used to initialize the codec's control_data field,
> but since this is also done by the snd-soc-cache core, the redundant
> assignment can be removed and the field can be dropped.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
Acked-by: Timur Tabi <timur@freescale.com>
Although Mark, it would have been nice if you had given me a chance to test this
change before applying the patch.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2011-09-28 19:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-28 2:00 [PATCH 1/6] ASoC: Remove unused "control_data" field of struct ak4671_priv Axel Lin
2011-09-28 2:01 ` [PATCH 2/6] ASoC: Remove unused "control_data" field of struct alc5623_priv Axel Lin
2011-09-28 2:10 ` [PATCH 3/6] ASoC: Remove unused "control_data" field of struct cs4270_private Axel Lin
2011-09-28 19:30 ` Timur Tabi [this message]
2011-09-28 19:30 ` Timur Tabi
2011-09-29 9:48 ` Mark Brown
2011-09-28 2:11 ` [PATCH 4/6] ASoC: Remove unused "control_data" field of struct cs42l51_private Axel Lin
2011-09-28 2:12 ` [PATCH 5/6] ASoC: Remove unused "control_data" field of struct max98088_priv Axel Lin
2011-09-28 2:14 ` [PATCH 6/6] ASoC: Remove unused "control_data" field of struct max98095_priv Axel Lin
2011-09-28 12:20 ` [PATCH 1/6] ASoC: Remove unused "control_data" field of struct ak4671_priv Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8375ED.1060209@freescale.com \
--to=timur@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.