* [PATCH] jffs2/security.c: local functions should be static
@ 2011-09-23 22:56 ` H Hartley Sweeten
0 siblings, 0 replies; 4+ messages in thread
From: H Hartley Sweeten @ 2011-09-23 22:56 UTC (permalink / raw)
To: Linux Kernel; +Cc: dwmw2, linux-mtd
Quiets the sparse noise:
warning: symbol 'jffs2_initxattrs' was not declared. Should it be static?
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: David Woodhouse <dwmw2@infradead.org>
---
diff --git a/fs/jffs2/security.c b/fs/jffs2/security.c
index 0f20208..aca97f3 100644
--- a/fs/jffs2/security.c
+++ b/fs/jffs2/security.c
@@ -23,8 +23,8 @@
#include "nodelist.h"
/* ---- Initial Security Label(s) Attachment callback --- */
-int jffs2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
- void *fs_info)
+static int jffs2_initxattrs(struct inode *inode,
+ const struct xattr *xattr_array, void *fs_info)
{
const struct xattr *xattr;
int err = 0;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] jffs2/security.c: local functions should be static
@ 2011-09-23 22:56 ` H Hartley Sweeten
0 siblings, 0 replies; 4+ messages in thread
From: H Hartley Sweeten @ 2011-09-23 22:56 UTC (permalink / raw)
To: Linux Kernel; +Cc: linux-mtd, dwmw2
Quiets the sparse noise:
warning: symbol 'jffs2_initxattrs' was not declared. Should it be static?
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: David Woodhouse <dwmw2@infradead.org>
---
diff --git a/fs/jffs2/security.c b/fs/jffs2/security.c
index 0f20208..aca97f3 100644
--- a/fs/jffs2/security.c
+++ b/fs/jffs2/security.c
@@ -23,8 +23,8 @@
#include "nodelist.h"
/* ---- Initial Security Label(s) Attachment callback --- */
-int jffs2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
- void *fs_info)
+static int jffs2_initxattrs(struct inode *inode,
+ const struct xattr *xattr_array, void *fs_info)
{
const struct xattr *xattr;
int err = 0;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] jffs2/security.c: local functions should be static
2011-09-23 22:56 ` H Hartley Sweeten
@ 2011-10-01 11:39 ` Artem Bityutskiy
-1 siblings, 0 replies; 4+ messages in thread
From: Artem Bityutskiy @ 2011-10-01 11:39 UTC (permalink / raw)
To: H Hartley Sweeten; +Cc: linux-mtd, dwmw2, Linux Kernel
On Fri, 2011-09-23 at 15:56 -0700, H Hartley Sweeten wrote:
> Quiets the sparse noise:
>
> warning: symbol 'jffs2_initxattrs' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: David Woodhouse <dwmw2@infradead.org>
Against which tree is this patch? My l2-mtd-2.6 tree does not have this
function, and it is based on Linux 3.1-rc2.
--
Best Regards,
Artem Bityutskiy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] jffs2/security.c: local functions should be static
@ 2011-10-01 11:39 ` Artem Bityutskiy
0 siblings, 0 replies; 4+ messages in thread
From: Artem Bityutskiy @ 2011-10-01 11:39 UTC (permalink / raw)
To: H Hartley Sweeten; +Cc: Linux Kernel, dwmw2, linux-mtd
On Fri, 2011-09-23 at 15:56 -0700, H Hartley Sweeten wrote:
> Quiets the sparse noise:
>
> warning: symbol 'jffs2_initxattrs' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: David Woodhouse <dwmw2@infradead.org>
Against which tree is this patch? My l2-mtd-2.6 tree does not have this
function, and it is based on Linux 3.1-rc2.
--
Best Regards,
Artem Bityutskiy
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-10-01 11:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-23 22:56 [PATCH] jffs2/security.c: local functions should be static H Hartley Sweeten
2011-09-23 22:56 ` H Hartley Sweeten
2011-10-01 11:39 ` Artem Bityutskiy
2011-10-01 11:39 ` Artem Bityutskiy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.