Re: [PATCH 2/6] Fix perl for powerpc64 build

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Wed, 2011-10-05 at 19:04 +0000, McClintock Matthew-B29882 wrote:
> On Wed, Oct 5, 2011 at 6:46 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> >> --- a/meta/recipes-devtools/perl/perl_5.12.3.bb
> >> +++ b/meta/recipes-devtools/perl/perl_5.12.3.bb
> >> @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://Copying;md5=2b4c6ffbcfcbdee469f02565f253d81a \
> >>  # We need gnugrep (for -I)
> >>  DEPENDS = "virtual/db grep-native"
> >>  DEPENDS += "gdbm zlib"
> >> -PR = "r5"
> >> +PR = "r6"
> >>
> >>  # 5.10.1 has Module::Build built-in
> >>  PROVIDES += "libmodule-build-perl"
> >> @@ -95,6 +95,8 @@ export LDDLFLAGS = "${LDFLAGS} -shared"
> >>  # We're almost Debian, aren't we?
> >>  CFLAGS += "-DDEBIAN"
> >>
> >> +export ARCH_powerpc64 = "powerpc64"
> >> +
> >
> > I'm finding it really hard to believe this makes any difference. I just
> > tried a powerpc64 build here and perl built fine. I can't find any
> > evidence for any part of the perl build using an ARCH variable
> > (TARGET_ARCH is used but that isn't ARCH).
> >
> > Can you give some further information about how/where this is used?
> 
> I'm trying to reproduce this again on 'edison' as well and it does not
> appear to be occurring anymore! The problem before had to do with a
> configuration script error:
> 
> config.sh-powerpc64-linux
> 
> This script was getting invoked as 'config.sh-powerpc-linux' on the
> 64bit build, then the file did not exist and the configure step failed
> out. Not sure if this was somehow fixed in a different manner.
> 
> Please drop this patch for now. I'll bring it up again if I see issues.

Do you still need this bit:

        case "${TARGET_ARCH}" in
-               x86_64 | powerpc | s390)
+               x86_64 | powerpc | powerpc64 | s390)
                        sed -i -e "s,\(need_va_copy=\)'undef',\1'define',g" \
                                config.sh-${TARGET_ARCH}-${TARGET_OS}
                        ;;

?

Cheers,

Richard