All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saul Wold <saul.wold@intel.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Cc: McClintock Matthew-B29882 <B29882@freescale.com>
Subject: Re: [PATCH 5/6] Fix sysprof for powerpc64
Date: Wed, 05 Oct 2011 10:10:41 -0700	[thread overview]
Message-ID: <4E8C8F91.1000203@intel.com> (raw)
In-Reply-To: <CAMKF1spCqBxZE=TyhremxN5NEC5fa9BuqJWYrCuTf4rk+bw4-Q@mail.gmail.com>

On 10/05/2011 10:06 AM, Khem Raj wrote:
> On Wed, Oct 5, 2011 at 9:48 AM, McClintock Matthew-B29882
> <B29882@freescale.com>  wrote:
>> On Wed, Oct 5, 2011 at 6:35 AM, Richard Purdie
>> <richard.purdie@linuxfoundation.org>  wrote:
>>>> this is a gcc built-in define I wonder why you need to add it explicitly
>>>
>>> Are you sure? Is the built-in define not __powerpc64__ ?
>>
>> Further investigation:
>>
>> [mattsm@right build_p5020ds-64b_release (testing $)]$
>> ./tmp/sysroots/x86_64-linux/usr/bin/ppc64e5500-fsl-linux/powerpc64-fsl-linux-gcc
>> -c -E -dM empty.c | grep __p
>> #define __powerpc64__ 1
>> #define __powerpc__ 1
>> [mattsm@right build_p5020ds-64b_release (testing $)]$
>
> yes I was trying it with a differently configured gcc. For linux gcc
> defines __powerpc64__
> and for darwin it has __ppc64__ as builtin define.
>
> I think adding check for __powerpc64__ and __powerpc__
> would be nice and can be submitted to sysprof upstream IMO
>
I think this would be a good fix to have in the upstream sysprof and it 
would remove the CFLAGS_append from the recipe.

Sau!

>>
>> -M
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>




  reply	other threads:[~2011-10-05 17:18 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-04 22:03 [PATCH 1/6] Fix mdadm for powerpc64 Matthew McClintock
2011-10-04 22:03 ` [PATCH 2/6] Fix perl for powerpc64 build Matthew McClintock
2011-10-05 11:46   ` Richard Purdie
2011-10-05 19:04     ` McClintock Matthew-B29882
2011-10-07 15:52       ` Richard Purdie
2011-10-07 16:07         ` McClintock Matthew-B29882
2011-10-04 22:03 ` [PATCH 3/6] Add new IMAGE_CLASSES variable for classes for image generation Matthew McClintock
2011-10-05 22:52   ` McClintock Matthew-B29882
2011-10-05 23:53     ` Richard Purdie
2011-10-06  0:25       ` McClintock Matthew-B29882
2011-10-11 16:44         ` McClintock Matthew-B29882
2011-10-04 22:03 ` [PATCH 4/6] scripts/oe-buildenv-internal: Add SOCKS5_{USER, PASSWD} to BB_ENV_EXTRAWHITE Matthew McClintock
2011-10-05 13:25   ` Richard Purdie
2011-10-04 22:03 ` [PATCH 5/6] Fix sysprof for powerpc64 Matthew McClintock
2011-10-05  0:05   ` Khem Raj
2011-10-05  6:44     ` McClintock Matthew-B29882
2011-10-05 11:35     ` Richard Purdie
2011-10-05 16:46       ` Khem Raj
2011-10-05 16:48       ` McClintock Matthew-B29882
2011-10-05 17:06         ` Khem Raj
2011-10-05 17:10           ` Saul Wold [this message]
2011-10-05 18:30       ` Phil Blundell
2011-10-05 18:41         ` McClintock Matthew-B29882
2011-10-05 19:13         ` Khem Raj
2011-10-04 22:03 ` [PATCH 6/6] Bring libnl up to date with meta-openebedded Matthew McClintock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E8C8F91.1000203@intel.com \
    --to=saul.wold@intel.com \
    --cc=B29882@freescale.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.