All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luciano Coelho <coelho@ti.com>
To: Arik Nemtsov <anamtsov@gmail.com>
Cc: Shahar Lev <shahar@wizery.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wl12xx: remove warning message during IBSS Tx
Date: Sat, 08 Oct 2011 22:45:27 +0300	[thread overview]
Message-ID: <1318103127.9690.46.camel@cumari> (raw)
In-Reply-To: <CA+XVXfd+vN7b=oYrysPCuynAgy5=4SgRHuznJRW0h+6ez7YqsQ@mail.gmail.com>

On Sat, 2011-10-08 at 21:19 +0200, Arik Nemtsov wrote: 
> On Fri, Oct 7, 2011 at 23:17, Luciano Coelho <coelho@ti.com> wrote:
> > On Fri, 2011-10-07 at 23:03 +0200, Shahar Lev wrote:
> >> On Fri, Oct 7, 2011 at 6:20 PM, Johannes Berg <johannes@sipsolutions.net> wrote:
> >> > Maybe you should also change that? :-)
> >>
> >> Consider it added to our collective TODO.
> >
> > Well, the fix is probably supposed to be done in mac80211, instead of
> > hiding the bug by removing the warning, isn't it?
> 
> Sometimes data is sent when the IBSS interface is not connected.
> wl12xx handles this correctly by throwing the packets. In this sense
> there's no "bug".
> All this patch does is remove warning messages that confuse the users
> (and developers).
> 
> I agree fixing mac80211 is the better thing to do, and we'll get to it
> when time permits.

Okay, not a big problem to do this in the driver.

But what I meant with "the bug" was that, if this can be avoided in
mac80211, why not do it there? Is it a a big effort to do it in
mac80211?


-- 
Cheers,
Luca.


  reply	other threads:[~2011-10-08 19:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-07 16:17 [PATCH] wl12xx: remove warning message during IBSS Tx Shahar Lev
2011-10-07 16:20 ` Johannes Berg
2011-10-07 21:03   ` Shahar Lev
2011-10-07 21:17     ` Luciano Coelho
2011-10-08 19:19       ` Arik Nemtsov
2011-10-08 19:45         ` Luciano Coelho [this message]
2011-10-08 19:55           ` Arik Nemtsov
2011-10-08 20:02             ` Luciano Coelho
2011-10-08 20:30               ` Shahar Lev
2011-10-11 14:43 ` Luciano Coelho
2011-10-11 16:18   ` Luciano Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1318103127.9690.46.camel@cumari \
    --to=coelho@ti.com \
    --cc=anamtsov@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=shahar@wizery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.