From: Luciano Coelho <coelho@ti.com>
To: Shahar Lev <shahar@wizery.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wl12xx: remove warning message during IBSS Tx
Date: Tue, 11 Oct 2011 19:18:40 +0300 [thread overview]
Message-ID: <1318349920.9690.529.camel@cumari> (raw)
In-Reply-To: <1318344193.9690.528.camel@cumari>
On Tue, 2011-10-11 at 17:43 +0300, Luciano Coelho wrote:
> On Fri, 2011-10-07 at 18:17 +0200, Shahar Lev wrote:
> > mac80211 sets the carrier on an IBSS interface even when no network is
> > joined. Ignore garbage frames transmitted on a disconnected IBSS
> > interface without printing warnings.
> >
> > Signed-off-by: Shahar Lev <shahar@wizery.com>
> > ---
>
> Applied, thanks!
Actually I had to merge this with Eliad's vif patches, so I did this
before applying:
diff --git a/drivers/net/wireless/wl12xx/tx.c b/drivers/net/wireless/wl12xx/tx.c
index 1bc00ca..27a45e1 100644
--- a/drivers/net/wireless/wl12xx/tx.c
+++ b/drivers/net/wireless/wl12xx/tx.c
@@ -429,7 +429,7 @@ static int wl1271_prepare_tx_frame(struct wl1271 *wl, struct wl12xx_vif *wlvif,
hlid = wl12xx_tx_get_hlid(wl, wlvif, skb);
if (hlid == WL12XX_INVALID_LINK_ID) {
if (wlvif->bss_type == BSS_TYPE_IBSS &&
- !test_bit(WL1271_FLAG_IBSS_JOINED, &wl->flags)) {
+ !test_bit(WLVIF_FLAG_IBSS_JOINED, &wlvif->flags)) {
/* It's ok to drop packets when not joined to IBSS */
wl1271_debug(DEBUG_TX, "dropping skb while IBSS not "
" joined");
--
Cheers,
Luca.
prev parent reply other threads:[~2011-10-11 16:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 16:17 [PATCH] wl12xx: remove warning message during IBSS Tx Shahar Lev
2011-10-07 16:20 ` Johannes Berg
2011-10-07 21:03 ` Shahar Lev
2011-10-07 21:17 ` Luciano Coelho
2011-10-08 19:19 ` Arik Nemtsov
2011-10-08 19:45 ` Luciano Coelho
2011-10-08 19:55 ` Arik Nemtsov
2011-10-08 20:02 ` Luciano Coelho
2011-10-08 20:30 ` Shahar Lev
2011-10-11 14:43 ` Luciano Coelho
2011-10-11 16:18 ` Luciano Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318349920.9690.529.camel@cumari \
--to=coelho@ti.com \
--cc=linux-wireless@vger.kernel.org \
--cc=shahar@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.