From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: target-devel <target-devel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
Roland Dreier <roland@purestorage.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 2/4] target: Re-org of core_tmr_lun_reset + FREE_CMD_INTR bugfix
Date: Sat, 08 Oct 2011 19:00:56 -0700 [thread overview]
Message-ID: <1318125656.4978.103.camel@haakon2.linux-iscsi.org> (raw)
In-Reply-To: <20111009013006.GB32104@infradead.org>
On Sat, 2011-10-08 at 21:30 -0400, Christoph Hellwig wrote:
> On Fri, Sep 30, 2011 at 04:55:09AM +0000, Nicholas A. Bellinger wrote:
> > This patch also includes a bugfix related to TRANSPORT_FREE_CMD_INTR
> > operation, where core_tmr_drain_cmd_list will skip this cause in order
> > to prevent an ABORT_TASK status from being returned for descriptors that
> > are already queued up to be related by processing thread context.
>
> Please try to avoid mixing random bux fixes into code reorganization.
>
>
Fair enough, i'm happy to break out this single bug-fix into a separate
patch for mainline.
> I also really hate adding more special cases for
> TRANSPORT_FREE_CMD_INTR. Freeing a command from interrupt should really
> done by using a qla2xxx specific workqueue, and the core should not know
> about the pending free before we call into transport_generic_free_cmd.
>
Yes, the usage of TRANSPORT_FREE_CMD_INTR with qla2xx is also
problematic with transport_generic_wait_for_tasks(), because readding
se_cmd via transport_add_cmd_to_queue() will reset the
cmd->t_transport_active bit..
Putting this into a qla2xxx specific workqueue is fine by me.
>
> This is pretty important for the conversion of the target execution
> model to concurrent workqueues in addition to simply not making the
> code a mess. I guess I'll have move making qla2xxx not abusing the
> processing thread for everything the highest priority in that area
> so that we don't get more special cases for it added.
>
> Except for that is looks fine to me.
>
Currently there are no additional TRANSPORT_FREE_CMD_INTR cases that we
have run into thus far.
--nab
next prev parent reply other threads:[~2011-10-09 2:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 4:55 [PATCH 0/4] target: LUN_RESET bugfixes for HW target mode Nicholas A. Bellinger
2011-09-30 4:55 ` [PATCH 1/4] target: Prevent cmd->se_queue_node double add Nicholas A. Bellinger
2011-10-09 1:24 ` Christoph Hellwig
2011-09-30 4:55 ` [PATCH 2/4] target: Re-org of core_tmr_lun_reset + FREE_CMD_INTR bugfix Nicholas A. Bellinger
2011-10-09 1:30 ` Christoph Hellwig
2011-10-09 2:00 ` Nicholas A. Bellinger [this message]
2011-09-30 4:55 ` [PATCH 3/4] target: Fix transport_cmd_finish_abort queue removal bug Nicholas A. Bellinger
2011-10-09 1:33 ` Christoph Hellwig
2011-10-09 2:03 ` Nicholas A. Bellinger
2011-10-09 2:27 ` Christoph Hellwig
2011-10-09 9:06 ` Nicholas A. Bellinger
2011-09-30 4:55 ` [PATCH 4/4] target: Prevent transport_send_task_abort when CHECK_CONDITION status Nicholas A. Bellinger
2011-09-30 5:25 ` [PATCH 0/4] target: LUN_RESET bugfixes for HW target mode Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318125656.4978.103.camel@haakon2.linux-iscsi.org \
--to=nab@linux-iscsi.org \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=roland@purestorage.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.