From: Christoph Hellwig <hch@infradead.org>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: Christoph Hellwig <hch@infradead.org>,
target-devel <target-devel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
Roland Dreier <roland@purestorage.com>
Subject: Re: [PATCH 3/4] target: Fix transport_cmd_finish_abort queue removal bug
Date: Sat, 8 Oct 2011 22:27:49 -0400 [thread overview]
Message-ID: <20111009022749.GB7948@infradead.org> (raw)
In-Reply-To: <1318125812.4978.106.camel@haakon2.linux-iscsi.org>
On Sat, Oct 08, 2011 at 07:03:32PM -0700, Nicholas A. Bellinger wrote:
> The reordering in transport_cmd_finish_abort() was not the issue here,
> but the calling transport_remove_cmd_from_queue() when 'remove == 0'.
>
> This should not be a problem in transport_cmd_finish_abort_tmr() as we
> always expect to release the tmr associated command.
I know, but I'd really not have subtily different calling conventions
between the two.
Right now transport_cmd_finish_abort and transport_cmd_finish_abort_tmr
only differ in:
- transport_cmd_finish_abort calling transport_lun_remove_cmd
- transport_cmd_finish_abort having the remove flag to make the
transport_put_cmd (and with your patch the
transport_remove_cmd_from_queue) call optional.
I'd much rather add a conditional on the command beeing a TMR and merge
the two into a single helper than having them diverge further.
next prev parent reply other threads:[~2011-10-09 2:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 4:55 [PATCH 0/4] target: LUN_RESET bugfixes for HW target mode Nicholas A. Bellinger
2011-09-30 4:55 ` [PATCH 1/4] target: Prevent cmd->se_queue_node double add Nicholas A. Bellinger
2011-10-09 1:24 ` Christoph Hellwig
2011-09-30 4:55 ` [PATCH 2/4] target: Re-org of core_tmr_lun_reset + FREE_CMD_INTR bugfix Nicholas A. Bellinger
2011-10-09 1:30 ` Christoph Hellwig
2011-10-09 2:00 ` Nicholas A. Bellinger
2011-09-30 4:55 ` [PATCH 3/4] target: Fix transport_cmd_finish_abort queue removal bug Nicholas A. Bellinger
2011-10-09 1:33 ` Christoph Hellwig
2011-10-09 2:03 ` Nicholas A. Bellinger
2011-10-09 2:27 ` Christoph Hellwig [this message]
2011-10-09 9:06 ` Nicholas A. Bellinger
2011-09-30 4:55 ` [PATCH 4/4] target: Prevent transport_send_task_abort when CHECK_CONDITION status Nicholas A. Bellinger
2011-09-30 5:25 ` [PATCH 0/4] target: LUN_RESET bugfixes for HW target mode Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111009022749.GB7948@infradead.org \
--to=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=roland@purestorage.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.