From: Joe Perches <joe@perches.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jiri Kosina <trivial@kernel.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org
Subject: Re: [PATCH] treewide: Use __printf not __attribute__((format(printf,...)))
Date: Tue, 11 Oct 2011 10:43:50 -0700 [thread overview]
Message-ID: <1318355030.8896.12.camel@Joe-Laptop> (raw)
In-Reply-To: <20111011172208.GA3633@shutemov.name>
On Tue, 2011-10-11 at 20:22 +0300, Kirill A. Shutemov wrote:
> On Thu, Aug 25, 2011 at 07:55:37PM -0700, Joe Perches wrote:
> > Standardize the style for compiler based printf format verification.
> > Standardized the location of __printf too.
> > Done via script and a little typing.
> > $ grep -rPl --include=*.[ch] -w "__attribute__" * | \
> > grep -vP "^(tools|scripts|include/linux/compiler-gcc.h)" | \
> > xargs perl -n -i -e 'local $/; while (<>) { s/\b__attribute__\s*\(\s*\(\s*format\s*\(\s*printf\s*,\s*(.+)\s*,\s*(.+)\s*\)\s*\)\s*\)/__printf($1, $2)/g ; print; }'
> > Completely untested...
> This patch breaks ARCH=um (linux-next-20111011):
Hi Kirill, thanks for reporting this.
I think it breaks almost all the the arches with modifications.
> In file included from /home/kas/git/public/linux-next/arch/um/os-Linux/aio.c:17:0:
> /home/kas/git/public/linux-next/arch/um/include/shared/user.h:26:17: error: expected declaration specifiers or ‘...’ before numeric constant
Hey Andrew, I think _all_ of the arch/... changes
except arch/frv and arch/s390 should be reverted.
Andrew, I don't know if you saw this:
https://lkml.org/lkml/2011/9/28/324
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jiri Kosina <trivial@kernel.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org
Subject: Re: [PATCH] treewide: Use __printf not __attribute__((format(printf,...)))
Date: Tue, 11 Oct 2011 10:43:50 -0700 [thread overview]
Message-ID: <1318355030.8896.12.camel@Joe-Laptop> (raw)
In-Reply-To: <20111011172208.GA3633@shutemov.name>
On Tue, 2011-10-11 at 20:22 +0300, Kirill A. Shutemov wrote:
> On Thu, Aug 25, 2011 at 07:55:37PM -0700, Joe Perches wrote:
> > Standardize the style for compiler based printf format verification.
> > Standardized the location of __printf too.
> > Done via script and a little typing.
> > $ grep -rPl --include=*.[ch] -w "__attribute__" * | \
> > grep -vP "^(tools|scripts|include/linux/compiler-gcc.h)" | \
> > xargs perl -n -i -e 'local $/; while (<>) { s/\b__attribute__\s*\(\s*\(\s*format\s*\(\s*printf\s*,\s*(.+)\s*,\s*(.+)\s*\)\s*\)\s*\)/__printf($1, $2)/g ; print; }'
> > Completely untested...
> This patch breaks ARCH=um (linux-next-20111011):
Hi Kirill, thanks for reporting this.
I think it breaks almost all the the arches with modifications.
> In file included from /home/kas/git/public/linux-next/arch/um/os-Linux/aio.c:17:0:
> /home/kas/git/public/linux-next/arch/um/include/shared/user.h:26:17: error: expected declaration specifiers or a??...a?? before numeric constant
Hey Andrew, I think _all_ of the arch/... changes
except arch/frv and arch/s390 should be reverted.
Andrew, I don't know if you saw this:
https://lkml.org/lkml/2011/9/28/324
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-10-11 17:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 20:26 [PATCH] mm: Neaten warn_alloc_failed Joe Perches
2011-08-25 20:26 ` Joe Perches
2011-08-25 23:50 ` Andrew Morton
2011-08-25 23:50 ` Andrew Morton
2011-08-26 0:00 ` Joe Perches
2011-08-26 0:00 ` Joe Perches
2011-08-26 0:05 ` Andrew Morton
2011-08-26 0:05 ` Andrew Morton
2011-08-26 0:38 ` Joe Perches
2011-08-26 0:38 ` Joe Perches
2011-08-26 1:07 ` Andrew Morton
2011-08-26 1:07 ` Andrew Morton
2011-08-26 2:55 ` [PATCH] treewide: Use __printf not __attribute__((format(printf,...))) Joe Perches
2011-08-26 2:55 ` Joe Perches
2011-10-11 17:22 ` Kirill A. Shutemov
2011-10-11 17:22 ` Kirill A. Shutemov
2011-10-11 17:22 ` Kirill A. Shutemov
2011-10-11 17:43 ` Joe Perches [this message]
2011-10-11 17:43 ` Joe Perches
[not found] ` <20111101150908.b482fad5.akpm@linux-foundation.org>
2011-11-02 2:27 ` [PATCH] checkpatch: Prefer " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318355030.8896.12.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.