From: Artem Bityutskiy <dedekind1@gmail.com>
To: Andres Salomon <dilinger@queued.net>
Cc: linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: rename the redboot module to RedBoot
Date: Fri, 14 Oct 2011 11:56:07 +0300 [thread overview]
Message-ID: <1318582575.12351.74.camel@sauron> (raw)
In-Reply-To: <20111003222346.5ac48654@queued.net>
On Mon, 2011-10-03 at 22:23 -0700, Andres Salomon wrote:
> parse_mtd_partitions takes a list of partition types; if the driver
> isn't loaded, it attempts to load it, and then it grabs the partition
> parser. For redboot, the module name is "redboot.ko", while the parser
> name is "RedBoot". Since modprobe is case-sensitive, attempting to
> modprobe "RedBoot" will never work. I suspect the embedded systems that
> make use of redboot just always manually loaded redboot prior to loading
> their specific nand chip drivers (or statically compiled it in).
>
> Alternatives include renaming the parser to "redboot", changing
> parse_mtd_partitions to accept pairs of strings, or changing modprobe
> to be case-insensitive. Renaming the module seems like the easy,
> obvious solution. :)
>
> Signed-off-by: Andres Salomon <dilinger@queued.net>
> ---
> drivers/mtd/Makefile | 2 +-
> drivers/mtd/RedBoot.c | 315 +++++++++++++++++++++++++++++++++++++++++++++++++
> drivers/mtd/redboot.c | 315 -------------------------------------------------
> 3 files changed, 316 insertions(+), 316 deletions(-)
> create mode 100644 drivers/mtd/RedBoot.c
> delete mode 100644 drivers/mtd/redboot.c
Could you please use MODULE_ALIAS(RedBoot) instead?
--
Best Regards,
Artem Bityutskiy
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Andres Salomon <dilinger@queued.net>
Cc: David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: rename the redboot module to RedBoot
Date: Fri, 14 Oct 2011 11:56:07 +0300 [thread overview]
Message-ID: <1318582575.12351.74.camel@sauron> (raw)
In-Reply-To: <20111003222346.5ac48654@queued.net>
On Mon, 2011-10-03 at 22:23 -0700, Andres Salomon wrote:
> parse_mtd_partitions takes a list of partition types; if the driver
> isn't loaded, it attempts to load it, and then it grabs the partition
> parser. For redboot, the module name is "redboot.ko", while the parser
> name is "RedBoot". Since modprobe is case-sensitive, attempting to
> modprobe "RedBoot" will never work. I suspect the embedded systems that
> make use of redboot just always manually loaded redboot prior to loading
> their specific nand chip drivers (or statically compiled it in).
>
> Alternatives include renaming the parser to "redboot", changing
> parse_mtd_partitions to accept pairs of strings, or changing modprobe
> to be case-insensitive. Renaming the module seems like the easy,
> obvious solution. :)
>
> Signed-off-by: Andres Salomon <dilinger@queued.net>
> ---
> drivers/mtd/Makefile | 2 +-
> drivers/mtd/RedBoot.c | 315 +++++++++++++++++++++++++++++++++++++++++++++++++
> drivers/mtd/redboot.c | 315 -------------------------------------------------
> 3 files changed, 316 insertions(+), 316 deletions(-)
> create mode 100644 drivers/mtd/RedBoot.c
> delete mode 100644 drivers/mtd/redboot.c
Could you please use MODULE_ALIAS(RedBoot) instead?
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2011-10-14 8:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-04 5:23 [PATCH] mtd: rename the redboot module to RedBoot Andres Salomon
2011-10-04 5:23 ` Andres Salomon
2011-10-14 8:56 ` Artem Bityutskiy [this message]
2011-10-14 8:56 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318582575.12351.74.camel@sauron \
--to=dedekind1@gmail.com \
--cc=dilinger@queued.net \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.