All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v4] fix implicit declaration of 'g_slist_free_full'
@ 2011-10-18 10:10 Frédéric Danis
  2011-10-18 10:30 ` Johan Hedberg
  0 siblings, 1 reply; 2+ messages in thread
From: Frédéric Danis @ 2011-10-18 10:10 UTC (permalink / raw)
  To: linux-bluetooth

audio/avrcp.c: In function 'avrcp_unregister':
audio/avrcp.c:1253: error: implicit declaration of function 'g_slist_free_full'

thermometer/thermometer.c: In function 'destroy_char':
thermometer/thermometer.c:79: error: implicit declaration of function 'g_slist_free_full'
---
 audio/avrcp.c             |    2 +-
 thermometer/thermometer.c |    5 +++++
 2 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/audio/avrcp.c b/audio/avrcp.c
index 75a8384..e908bf4 100644
--- a/audio/avrcp.c
+++ b/audio/avrcp.c
@@ -52,7 +52,7 @@
 #include "avctp.h"
 #include "avrcp.h"
 #include "sdpd.h"
-#include "glib-helper.h"
+#include "glib-compat.h"
 #include "dbus-common.h"
 
 /* Company IDs for vendor dependent commands */
diff --git a/thermometer/thermometer.c b/thermometer/thermometer.c
index 7621926..0d85102 100644
--- a/thermometer/thermometer.c
+++ b/thermometer/thermometer.c
@@ -20,6 +20,10 @@
  *
  */
 
+#ifdef HAVE_CONFIG_H
+#include <config.h>
+#endif
+
 #include <gdbus.h>
 #include <errno.h>
 #include <bluetooth/uuid.h>
@@ -34,6 +38,7 @@
 #include "att.h"
 #include "gatt.h"
 #include "thermometer.h"
+#include "glib-compat.h"
 
 #define THERMOMETER_INTERFACE "org.bluez.Thermometer"
 
-- 
1.7.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v4] fix implicit declaration of 'g_slist_free_full'
  2011-10-18 10:10 [PATCH v4] fix implicit declaration of 'g_slist_free_full' Frédéric Danis
@ 2011-10-18 10:30 ` Johan Hedberg
  0 siblings, 0 replies; 2+ messages in thread
From: Johan Hedberg @ 2011-10-18 10:30 UTC (permalink / raw)
  To: Frédéric Danis; +Cc: linux-bluetooth

Hi Frédéric,

On Tue, Oct 18, 2011, Frédéric Danis wrote:
> audio/avrcp.c: In function 'avrcp_unregister':
> audio/avrcp.c:1253: error: implicit declaration of function 'g_slist_free_full'
> 
> thermometer/thermometer.c: In function 'destroy_char':
> thermometer/thermometer.c:79: error: implicit declaration of function 'g_slist_free_full'
> ---
>  audio/avrcp.c             |    2 +-
>  thermometer/thermometer.c |    5 +++++
>  2 files changed, 6 insertions(+), 1 deletions(-)

Applied. Thanks.

Btw, to be consistent with the commit history, in the future please
start the commit message with a capital letter, i.e. "Fix.." instead of
"fix..".

Johan

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-10-18 10:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-18 10:10 [PATCH v4] fix implicit declaration of 'g_slist_free_full' Frédéric Danis
2011-10-18 10:30 ` Johan Hedberg

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.