[PATCH 0/1] Fix a silly hob bug

[PATCH 0/1] Fix a silly hob bug

[Joshua Lock]

Dismissing the open file dialog in hob results in a backtrace, this is due
to a stupid logic/indentation error on my part - the following patch
rectifies this.

Regards,
Joshua

The following changes since commit dca46cc2e1c75b6add2c4801e2994a4812745f5b:

  fetch2: Export additional variables to the fetchers (2011-10-05 14:23:16 +0100)

are available in the git repository at:
  git://github.com/incandescant/bitbake hob
  https://github.com/incandescant/bitbake/tree/hob

Joshua Lock (1):
  hob: fix backtrace when dismissing open dialog

 lib/bb/ui/hob.py |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

-- 
1.7.6.4

[PATCH 1/1] hob: fix backtrace when dismissing open dialog

[Joshua Lock]

Clearly a logic/indentation error - we should only try and load the recipe
should the file-chooser return OK.

Fixes [YOCTO #1668]

Signed-off-by: Joshua Lock <josh@linux.intel.com>
---
 lib/bb/ui/hob.py |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/bb/ui/hob.py b/lib/bb/ui/hob.py
index 71ea88a..0fcaad5 100644
--- a/lib/bb/ui/hob.py
+++ b/lib/bb/ui/hob.py
@@ -400,9 +400,9 @@ class MainWindow (gtk.Window):
         if response == gtk.RESPONSE_OK:
             rep.loadRecipe(recipe)
             self.save_path = recipe
+            self.model.load_image_rep(rep)
+            self.dirty = False
         chooser.destroy()
-        self.model.load_image_rep(rep)
-        self.dirty = False
 
     def bake_clicked_cb(self, button):
         build_image = True
-- 
1.7.6.4

Re: [PATCH 1/1] hob: fix backtrace when dismissing open dialog

[Richard Purdie]

On Tue, 2011-10-11 at 10:20 -0700, Joshua Lock wrote:
> Clearly a logic/indentation error - we should only try and load the recipe
> should the file-chooser return OK.
> 
> Fixes [YOCTO #1668]
> 
> Signed-off-by: Joshua Lock <josh@linux.intel.com>
> ---
>  lib/bb/ui/hob.py |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Merged to master, thanks.

Richard