Re: Linux USB HID should ignore values outside Logical Minimum/Maximum range

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Christoph Fritz <chf.fritz@googlemail.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Denilson Figueiredo de Sá" <denilsonsa@gmail.com>,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: Re: Linux USB HID should ignore values outside Logical Minimum/Maximum range
Date: Fri, 28 Oct 2011 21:27:00 +0200	[thread overview]
Message-ID: <1319830020.3467.7.camel@lovely> (raw)
In-Reply-To: <alpine.LNX.2.00.1110281817380.3541@pobox.suse.cz>

On Fri, 2011-10-28 at 18:23 +0200, Jiri Kosina wrote:
> On Mon, 24 Oct 2011, Dmitry Torokhov wrote:
> 
> > While input core does not clam or validate the values reported by the 
> > driver it might make sense to do so in hid-input; I am not sure how 
> > often these limits programmed intorrectly. Jiri i sprobably the best 
> > person to answer this question.
> 
> I haven't met such a device myself yet.
> 
> On the other hand I feel like just dropping the report on the floor should 
> be the proper thing to do.
> 
> 
> Christoph, how about the (untested at my side yet) patch below? It'd be 
> nice if you could test with the device you are seeing the problem with and 
> let me know.


I don't have this device and I'm not the person who started this thread.
It's Denilson Figueiredo de Sá <denilsonsa@gmail.com> , just see above.

Denilson, please comment.

Thanks,
 -- Christoph


--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)

From: Christoph Fritz <chf.fritz@googlemail.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Denilson Figueiredo de Sá" <denilsonsa@gmail.com>,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: Re: Linux USB HID should ignore values outside Logical Minimum/Maximum range
Date: Fri, 28 Oct 2011 21:27:00 +0200	[thread overview]
Message-ID: <1319830020.3467.7.camel@lovely> (raw)
In-Reply-To: <alpine.LNX.2.00.1110281817380.3541@pobox.suse.cz>

On Fri, 2011-10-28 at 18:23 +0200, Jiri Kosina wrote:
> On Mon, 24 Oct 2011, Dmitry Torokhov wrote:
> 
> > While input core does not clam or validate the values reported by the 
> > driver it might make sense to do so in hid-input; I am not sure how 
> > often these limits programmed intorrectly. Jiri i sprobably the best 
> > person to answer this question.
> 
> I haven't met such a device myself yet.
> 
> On the other hand I feel like just dropping the report on the floor should 
> be the proper thing to do.
> 
> 
> Christoph, how about the (untested at my side yet) patch below? It'd be 
> nice if you could test with the device you are seeing the problem with and 
> let me know.


I don't have this device and I'm not the person who started this thread.
It's Denilson Figueiredo de Sá <denilsonsa@gmail.com> , just see above.

Denilson, please comment.

Thanks,
 -- Christoph

next prev parent reply	other threads:[~2011-10-28 19:19 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-22 11:42 Linux USB HID should ignore values outside Logical Minimum/Maximum range Denilson Figueiredo de Sá
2011-10-24 16:24 ` Chris Friesen
2011-10-24 16:24   ` Chris Friesen
2011-10-24 16:39   ` Denilson Figueiredo de Sá
2011-10-24 16:39     ` Denilson Figueiredo de Sá
2011-10-24 20:35     ` Dmitry Torokhov
2011-10-25  4:03     ` Denilson Figueiredo de Sá
2011-10-25  4:03       ` Denilson Figueiredo de Sá
2011-10-24 17:09 ` Christoph Fritz
2011-10-24 17:09   ` Christoph Fritz
2011-10-24 17:04   ` Denilson Figueiredo de Sá
2011-10-24 20:32   ` Dmitry Torokhov
2011-10-28 16:23     ` Jiri Kosina
2011-10-28 16:23       ` Jiri Kosina
2011-10-28 19:27       ` Christoph Fritz [this message]
2011-10-28 19:27         ` Christoph Fritz
2011-10-28 20:40       ` Denilson Figueiredo de Sá
2011-10-31 15:24         ` Jiri Kosina
2011-10-31 15:24           ` Jiri Kosina
2011-11-02 23:39           ` Denilson Figueiredo de Sá
2011-11-16 14:01             ` Jiri Kosina
2011-11-16 14:01               ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1319830020.3467.7.camel@lovely \
    --to=chf.fritz@googlemail.com \
    --cc=denilsonsa@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.