From: Peter Bergner <bergner@vnet.ibm.com>
To: Santosh Kumar <santoshkumar.a@gmail.com>
Cc: Michael Neuling <mikey@neuling.org>,
Ian Munsie <ianmunsi@au1.ibm.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: powerpc 476, Little-endian, pte fault
Date: Tue, 01 Nov 2011 08:44:34 -0500 [thread overview]
Message-ID: <1320155074.2996.190.camel@otta> (raw)
In-Reply-To: <CAJw04pBpXsTS4=FeG5ZF3nqORXhiOZ=3V60cFCuJfgTiJcCh2g@mail.gmail.com>
On Tue, 2011-11-01 at 08:32 +0530, Santosh Kumar wrote:
> I am using the same compiler as 476 & 440 instruction is almost the same.
Well the 476 implements ISA 2.05, which I think has added a fair amount
over the 440. Not to mention the 476 core that has been released has
a FP unit. I'll note that GCC has support for a 476 with and without
a FP unit, even though AFAIK, we only ship one with a FP unit.
The relevant options are -mcpu=476 (no FP unit) and -mcpu=476fp
(with FP unit). Basically, -mcpu=476 is equivalent to
-mcpu=476fp -msoft-float.
> @@ -53,7 +58,12 @@
> mullw r10,r0,r4 # and get the remainder
> add r8,r8,r0
> subf r6,r10,r6
> +#ifdef CONFIG_INVADER
> 4: stw r7,0(r3) # return the quotient in *r3
> stw r8,4(r3)
> +#else
> +4: stw r7,0(r3) # return the quotient in *r3
> + stw r8,4(r3)
> +#endif
> mr r3,r6 # return the remainder in r3
> blr
This looks like a typo, since you didn't actually swap the offsets
on the stw's like you did in all of the other patch hunks.
Peter
WARNING: multiple messages have this Message-ID (diff)
From: Peter Bergner <bergner@vnet.ibm.com>
To: Santosh Kumar <santoshkumar.a@gmail.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linuxppc-dev@ozlabs.org, Michael Neuling <mikey@neuling.org>,
Ian Munsie <ianmunsi@au1.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: powerpc 476, Little-endian, pte fault
Date: Tue, 01 Nov 2011 08:44:34 -0500 [thread overview]
Message-ID: <1320155074.2996.190.camel@otta> (raw)
In-Reply-To: <CAJw04pBpXsTS4=FeG5ZF3nqORXhiOZ=3V60cFCuJfgTiJcCh2g@mail.gmail.com>
On Tue, 2011-11-01 at 08:32 +0530, Santosh Kumar wrote:
> I am using the same compiler as 476 & 440 instruction is almost the same.
Well the 476 implements ISA 2.05, which I think has added a fair amount
over the 440. Not to mention the 476 core that has been released has
a FP unit. I'll note that GCC has support for a 476 with and without
a FP unit, even though AFAIK, we only ship one with a FP unit.
The relevant options are -mcpu=476 (no FP unit) and -mcpu=476fp
(with FP unit). Basically, -mcpu=476 is equivalent to
-mcpu=476fp -msoft-float.
> @@ -53,7 +58,12 @@
> mullw r10,r0,r4 # and get the remainder
> add r8,r8,r0
> subf r6,r10,r6
> +#ifdef CONFIG_INVADER
> 4: stw r7,0(r3) # return the quotient in *r3
> stw r8,4(r3)
> +#else
> +4: stw r7,0(r3) # return the quotient in *r3
> + stw r8,4(r3)
> +#endif
> mr r3,r6 # return the remainder in r3
> blr
This looks like a typo, since you didn't actually swap the offsets
on the stw's like you did in all of the other patch hunks.
Peter
next prev parent reply other threads:[~2011-11-01 13:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 5:30 powerpc 476, Little-endian, pte fault Santosh Kumar
2011-10-31 5:51 ` Michael Neuling
2011-10-31 5:51 ` Michael Neuling
2011-10-31 6:35 ` Santosh Kumar
2011-10-31 7:38 ` Santosh Kumar
2011-10-31 7:38 ` Santosh Kumar
2011-10-31 9:49 ` Michael Neuling
2011-10-31 9:49 ` Michael Neuling
2011-10-31 11:23 ` Benjamin Herrenschmidt
2011-10-31 11:23 ` Benjamin Herrenschmidt
2011-11-01 3:02 ` Santosh Kumar
2011-11-01 3:02 ` Santosh Kumar
2011-11-01 13:44 ` Peter Bergner [this message]
2011-11-01 13:44 ` Peter Bergner
2011-11-01 17:14 ` Santosh Kumar
2011-11-01 17:14 ` Santosh Kumar
2011-11-01 18:44 ` Peter Bergner
2011-11-01 18:44 ` Peter Bergner
2011-10-31 7:48 ` Shan Hai
2011-10-31 9:17 ` Santosh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320155074.2996.190.camel@otta \
--to=bergner@vnet.ibm.com \
--cc=ianmunsi@au1.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=santoshkumar.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.