From: Brian J. Murrell <brian@whamcloud.com>
To: lustre-devel@lists.lustre.org
Subject: [Lustre-devel] [wc-discuss] Lustre code style Git commit hooks and
Date: Fri, 04 Nov 2011 17:47:42 -0400 [thread overview]
Message-ID: <1320443263.7466.26.camel@brian-laptop> (raw)
In-Reply-To: <8FB8F9D4-A179-490D-AE9F-61C731FD98AA@whamcloud.com>
On Fri, 2011-11-04 at 10:40 -0600, Andreas Dilger wrote:
> On 2011-11-03, at 4:28 PM, Prakash Surya <surya1@llnl.gov> wrote:
> > I like the idea of cleaning up the commit messages in Lustre, although I
> > feel enforcing these rules is better suited at the server level.
>
> There are already limited checks at the server level, and they may be tightened in the near future.
And the most the server (which is Gerrit that we are talking about her)
can do is to negatively review the patch as it does currently. There is
no mechanism to outright refuse to allow a push based on the content of
the patch, so client-side is still the best place to apply these checks
in an effort to prevent the patch from even being submitted if not
correct.
b.
next prev parent reply other threads:[~2011-11-04 21:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-02 19:17 [Lustre-devel] Lustre code style Git commit hooks and Andreas Dilger
2011-11-03 22:28 ` [Lustre-devel] [wc-discuss] " Prakash Surya
2011-11-04 16:40 ` Andreas Dilger
2011-11-04 21:47 ` Brian J. Murrell [this message]
2011-11-09 16:27 ` James Simmons
2011-11-09 17:04 ` Andreas Dilger
2011-11-09 17:40 ` Prakash Surya
2011-11-09 19:23 ` James Simmons
2011-11-09 22:00 ` [Lustre-devel] [wc-discuss] Lustre code style Git commit hooks Andreas Dilger
2011-11-14 16:08 ` James Simmons
2011-11-14 18:10 ` Prakash Surya
2011-11-14 19:14 ` James Simmons
2011-11-15 8:55 ` Andreas Dilger
2011-11-15 14:23 ` Bruce Korb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320443263.7466.26.camel@brian-laptop \
--to=brian@whamcloud.com \
--cc=lustre-devel@lists.lustre.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.