[Lustre-devel] [wc-discuss] Lustre code style Git commit hooks and

[Prakash Surya <surya1@llnl.gov>]

On Wed, Nov 09, 2011 at 09:04:58AM -0800, Andreas Dilger wrote:
> On 2011-11-09, at 9:27 AM, James Simmons <jsimmons@infradead.org> wrote:
> > 
> >>> 
> > Speaking of I just attempted to push a patch and noticed that no Change-Id 
> > is being generated when I commit a new patch. This is with the default 
> > hooks that I copied form build directory.
> 
> Is this from the tip of the master branch?
> 
> An earlier version of the commit-msg hook used "git hash-object -t commit" and it caused an empty Change-Id string for older versions of Git. The "-t commit" option was removed from the latest version and solved the problem for the people that used it.
> 
> If updating to the latest version (or removing "-t commit") my fix this for you, please file a bug assigned to me and we can work it out. 
> 
> The contents of the .git directory are not under revision control, so it isn't possible to automatically update the commit hooks. At some point I'd like to update the hooks via "make", but was holding off until I have more confidence that issues like this related to different development environments are fixed. 

Alternatively, one could also use symlinks in .git to point to the files
in the lustre build directory. It's kind of a hack, but it keeps the
hooks up to date. And that way, the lustre build process doesn't have
to muck with the user's .git directory.

> 
> Thanks for the feedback. 
> 
> Cheers, Andreas
> _______________________________________________
> Lustre-devel mailing list
> Lustre-devel at lists.lustre.org
> http://lists.lustre.org/mailman/listinfo/lustre-devel

-- 
Cheers,
Prakash