From: Colin Walters <walters@verbum.org>
To: poky@yoctoproject.org
Subject: non-upstreamed patches
Date: Sat, 12 Nov 2011 19:57:33 -0500 [thread overview]
Message-ID: <1321145853.14976.12.camel@lenny> (raw)
So I've switched back to looking at Yocto again for a project, and the
Edison release works fine. Thanks!
I work on GNOME (almost all of it), and I see quite a number of patches
in the Yocto tree that I think have been inappropriately categorized as
Upstream-Status: Inappropriate.
For example,
recipies-core/glib-2.0/glib-2.0/remove.test.for.qsort_r.patch
We definitely want upstream GLib to work for cross builds. It was my
understanding that the better way to handle autoconf checks that require
running code was to pass a precomputed cache file:
http://www.gnu.org/s/hello/manual/autoconf/Site-Defaults.html
I think this makes sense to do for fundamental libraries like GLib;
hacking up the configure.ac isn't a good long term plan.
Another thing that seems to be proliferating is gtk-doc workarounds. If
it isn't working for you guys to --disable-gtk-doc, just tell me why and
I'll fix it.
(The -Werror bit there is a total fuckup on our part, I will eventually
convince Owen to remove it...)
librsvg/librsvg-2.31.1/doc_Makefile.patch is also TOTALLY appropriate
upstream. Why would you think it isn't?
gtk+/gtk+-2.24.6/run-iconcache.patch is another cross build issue that
I'm pretty sure we can solve better upstream. gtk+ for example already
has an automake conditional:
AM_CONDITIONAL(CROSS_COMPILING, test $cross_compiling = yes)
We can just not run this code if that's true.
(And I am totally fine with just copying that conditional into every
single GNOME module).
hardcoded_libtool.patch is another one I think we can get upstream in a
better way; shouldn't it just be using $LIBTOOL ?
Finally, on the Upstream-Status: pending patches, can you guys please
add links to bugzilla?
Thanks!
next reply other threads:[~2011-11-13 0:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-13 0:57 Colin Walters [this message]
2011-11-13 9:28 ` non-upstreamed patches Koen Kooi
2011-11-13 17:16 ` Colin Walters
2011-11-13 19:51 ` Koen Kooi
2011-11-13 9:47 ` Richard Purdie
2011-11-14 19:06 ` Colin Walters
2011-11-14 19:56 ` Richard Purdie
2011-11-14 20:48 ` Colin Walters
2011-11-14 22:44 ` Richard Purdie
2011-11-15 0:05 ` Colin Walters
2011-11-15 0:19 ` Richard Purdie
2012-01-03 18:45 ` Colin Walters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321145853.14976.12.camel@lenny \
--to=walters@verbum.org \
--cc=poky@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.