All of lore.kernel.org
 help / color / mirror / Atom feed
From: Colin Walters <walters@verbum.org>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: poky@yoctoproject.org
Subject: Re: non-upstreamed patches
Date: Mon, 14 Nov 2011 19:05:33 -0500	[thread overview]
Message-ID: <1321315533.1741.26.camel@lenny> (raw)
In-Reply-To: <1321310649.26881.103.camel@ted>

On Mon, 2011-11-14 at 22:44 +0000, Richard Purdie wrote:

> Well, I went and looked at the gnome-common autogen stuff. Its not a
> cross specific problem in this case but it does seem to
> reinvent/reimplement pieces of what autoconf/pkgconfig is supposed to
> do. Compare/check autoconf version? automake version? pkg-config
> dependencies present? Why? The whole point of autoconf was to avoid
> having these scripts :(

They serve a few purposes; one is simply helping people who check out a
given module from git know they have compatible versions of the
autotools.  This used to be a major problem, nowadays it's been a long
time since any kind serious of autotools incompatibilities.

The still-relevant issue though is that autoreconf isn't extensible - in
GNOME for better or worse we have two things that follow the auto* style
(gtk-doc and intltool mainly) where they copy data into your system if
building from git, and get shipped in tarballs so you don't need them at
build time when building from tarballs.

But we have no way to tell autoreconf to run these tools currently.
Maybe the right thing is to extend autoreconf but even if we did that,
we'd have to wait some amount of time before assuming everyone had the
modified autoreconf.

> Our current hack is really the former approach - add dummy copies in.
> Its just a little incomplete and we should enhance it deal with that so
> we can run gtkdocize.

Hmmm...so we'd be patching autotools.bbclass to grep for e.g.
GTK_DOC_CHECK in configure.ac and if detected, copy in a dummy
gtk-doc.make and gtk-doc.m4?

(And the same for intltool?)

I wouldn't object too much to that I guess, but I'd still prefer the
solution where we opt-in to running autogen.sh for GNOME modules which
use gtk-doc and/or intltool.




  reply	other threads:[~2011-11-15  0:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-13  0:57 non-upstreamed patches Colin Walters
2011-11-13  9:28 ` Koen Kooi
2011-11-13 17:16   ` Colin Walters
2011-11-13 19:51     ` Koen Kooi
2011-11-13  9:47 ` Richard Purdie
2011-11-14 19:06   ` Colin Walters
2011-11-14 19:56     ` Richard Purdie
2011-11-14 20:48       ` Colin Walters
2011-11-14 22:44         ` Richard Purdie
2011-11-15  0:05           ` Colin Walters [this message]
2011-11-15  0:19             ` Richard Purdie
2012-01-03 18:45             ` Colin Walters

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321315533.1741.26.camel@lenny \
    --to=walters@verbum.org \
    --cc=poky@yoctoproject.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.