From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, shemminger@linux-foundation.org,
bridge@lists.linux-foundation.org, holger.brunck@keymile.com,
Wolfgang.Fritz@keymile.com
Subject: Re: [Bridge] [PATCH] net, bridge: print log message after state changed
Date: Mon, 14 Nov 2011 06:27:50 -0800 [thread overview]
Message-ID: <1321280870.2004.2.camel@Joe-Laptop> (raw)
In-Reply-To: <20111114.020749.1176229013272872343.davem@davemloft.net>
On Mon, 2011-11-14 at 02:07 -0500, David Miller wrote:
> I would never expect an "entering" message to print out after the event
> happens, and in fact I'd _always_ want to see it beforehand so that if
> the state change caused a crash or similar it'd be that much easier
> to pinpoint the proper location.
>
> I'm still not applying this. If the other log messages behave
> differently, they are broken, so go fix those instead.
Perhaps use "entered" after the transition or "entering" before.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: Wolfgang.Fritz@keymile.com, holger.brunck@keymile.com,
netdev@vger.kernel.org, shemminger@linux-foundation.org,
bridge@lists.linux-foundation.org
Subject: Re: [PATCH] net, bridge: print log message after state changed
Date: Mon, 14 Nov 2011 06:27:50 -0800 [thread overview]
Message-ID: <1321280870.2004.2.camel@Joe-Laptop> (raw)
In-Reply-To: <20111114.020749.1176229013272872343.davem@davemloft.net>
On Mon, 2011-11-14 at 02:07 -0500, David Miller wrote:
> I would never expect an "entering" message to print out after the event
> happens, and in fact I'd _always_ want to see it beforehand so that if
> the state change caused a crash or similar it'd be that much easier
> to pinpoint the proper location.
>
> I'm still not applying this. If the other log messages behave
> differently, they are broken, so go fix those instead.
Perhaps use "entered" after the transition or "entering" before.
next prev parent reply other threads:[~2011-11-14 14:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-10 16:18 [Bridge] [PATCH] net, bridge: print log message after state changed Holger Brunck
2011-11-10 16:18 ` Holger Brunck
2011-11-14 5:37 ` [Bridge] " David Miller
2011-11-14 5:37 ` David Miller
2011-11-14 7:03 ` Fritz, Wolfgang
2011-11-14 7:13 ` [Bridge] " Fritz, Wolfgang
2011-11-14 7:07 ` David Miller
2011-11-14 7:07 ` David Miller
2011-11-14 9:09 ` [Bridge] " Fritz, Wolfgang
2011-11-14 9:10 ` Fritz, Wolfgang
2011-11-14 14:27 ` Joe Perches [this message]
2011-11-14 14:27 ` Joe Perches
2011-11-17 6:19 ` [Bridge] " Valerio Granato
2011-11-17 19:23 ` David Lamparter
2011-11-17 19:23 ` David Lamparter
2011-11-17 22:40 ` [Bridge] " Stephen Hemminger
2011-11-17 22:40 ` Stephen Hemminger
2011-11-18 9:20 ` Holger Brunck
2011-11-18 9:30 ` [Bridge] " Holger Brunck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321280870.2004.2.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=Wolfgang.Fritz@keymile.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=holger.brunck@keymile.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.