Re: [PATCH] mac80211: Add NoAck per WMM Queue Support

[Johannes Berg <johannes@sipsolutions.net>]

On Wed, 2011-11-16 at 08:46 +0100, Felix Fietkau wrote:
> On 2011-11-16 12:21 AM, Simon Wunderlich wrote:
> > This patch adds support for NoAck per WMM Queue. The Unicast QoS
> > Header is adapted accordingly for each outgoing frame.
> > The support is turned on and off through nl80211 by extending
> > the WMM TX Queue Parameters, but can be triggered separately.
> > 
> > I have tested this feature on ath9k as well as ath5k devices. There is
> > an iw patch as well to make use of this feature.
> > 
> > It should apply well on the latest wireless-testing kernel.

> > +	int	(*set_txq_noack)(struct wiphy *wiphy, struct net_device *dev,
> > +				  struct ieee80211_txq_params *params);
> > +
> >  	int	(*set_channel)(struct wiphy *wiphy, struct net_device *dev,
> >  			       struct ieee80211_channel *chan,
> >  			       enum nl80211_channel_type channel_type);
> Why add a separate cfg80211 op when you can just make use of the extra
> parameter in the existing one?

Can't actually -- that one's only allowed in AP mode :)

FWIW I think this API would also better be per connection or so.

johannes