* [PATCH] ASoC: cs42l73: Make inv and format to be unsigned int
@ 2011-11-18 9:16 Axel Lin
2011-11-18 14:49 ` Brian Austin
2011-11-22 13:02 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2011-11-18 9:16 UTC (permalink / raw)
To: alsa-devel
Cc: Vinod Koul, Mark Brown, Brian Austin, Georgi Vlaev, Liam Girdwood,
Dan Carpenter
Fix below smatch warning:
sound/soc/codecs/cs42l73.c +1030 cs42l73_set_dai_fmt(53) error: inv is never equal to 1024 (wrong type 0 - 255).
sound/soc/codecs/cs42l73.c +1032 cs42l73_set_dai_fmt(55) error: inv is never equal to 768 (wrong type 0 - 255).
sound/soc/codecs/cs42l73.c +1036 cs42l73_set_dai_fmt(59) error: inv is never equal to 1024 (wrong type 0 - 255).
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/codecs/cs42l73.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/cs42l73.c b/sound/soc/codecs/cs42l73.c
index a2af595..aadfd6b 100644
--- a/sound/soc/codecs/cs42l73.c
+++ b/sound/soc/codecs/cs42l73.c
@@ -979,7 +979,7 @@ static int cs42l73_set_dai_fmt(struct snd_soc_dai *codec_dai, unsigned int fmt)
struct snd_soc_codec *codec = codec_dai->codec;
struct cs42l73_private *priv = snd_soc_codec_get_drvdata(codec);
u8 id = codec_dai->id;
- u8 inv, format;
+ unsigned int inv, format;
u8 spc, mmcc;
spc = snd_soc_read(codec, CS42L73_SPC(id));
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: cs42l73: Make inv and format to be unsigned int
2011-11-18 9:16 [PATCH] ASoC: cs42l73: Make inv and format to be unsigned int Axel Lin
@ 2011-11-18 14:49 ` Brian Austin
2011-11-22 13:02 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Brian Austin @ 2011-11-18 14:49 UTC (permalink / raw)
To: Axel Lin; +Cc: alsa-devel, Brian Austin, Dan Carpenter
On Fri, 18 Nov 2011, Axel Lin wrote:
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Thanks for the checks
-brian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: cs42l73: Make inv and format to be unsigned int
2011-11-18 9:16 [PATCH] ASoC: cs42l73: Make inv and format to be unsigned int Axel Lin
2011-11-18 14:49 ` Brian Austin
@ 2011-11-22 13:02 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2011-11-22 13:02 UTC (permalink / raw)
To: Axel Lin
Cc: Brian Austin, Vinod Koul, alsa-devel, Georgi Vlaev, Liam Girdwood,
Dan Carpenter
On Fri, Nov 18, 2011 at 05:16:22PM +0800, Axel Lin wrote:
> Fix below smatch warning:
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-22 13:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-18 9:16 [PATCH] ASoC: cs42l73: Make inv and format to be unsigned int Axel Lin
2011-11-18 14:49 ` Brian Austin
2011-11-22 13:02 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.