* [PATCH 1/2] bitbake.conf: add a couple explicit vardeps
@ 2011-11-16 21:17 Chris Larson
2011-11-18 14:29 ` Richard Purdie
0 siblings, 1 reply; 3+ messages in thread
From: Chris Larson @ 2011-11-16 21:17 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
Signed-off-by: Christopher Larson <chris_larson@mentor.com>
---
meta/conf/bitbake.conf | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 0d6b3b8..c158c61 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -506,6 +506,7 @@ DEBUG_FLAGS ?= "-g -feliminate-unused-debug-types"
FULL_OPTIMIZATION = "-O2 -pipe ${DEBUG_FLAGS}"
DEBUG_OPTIMIZATION = "-O -fno-omit-frame-pointer ${DEBUG_FLAGS} -pipe"
SELECTED_OPTIMIZATION = "${@bb.data.getVar(['FULL_OPTIMIZATION',
'DEBUG_OPTIMIZATION'][d.getVar('DEBUG_BUILD', 1) == '1'], d, 1)}"
+SELECTED_OPTIMIZATION[vardeps] += "FULL_OPTIMIZATION DEBUG_OPTIMIZATION"
BUILD_OPTIMIZATION = "-O2 -pipe"
##################################################################
@@ -717,6 +718,7 @@ COMBINED_FEATURES = "\
${@base_both_contain("DISTRO_FEATURES", "MACHINE_FEATURES",
"usbgadget", d)} \
${@base_both_contain("DISTRO_FEATURES", "MACHINE_FEATURES",
"usbhost", d)} \
${@base_both_contain("DISTRO_FEATURES", "MACHINE_FEATURES", "wifi", d)}"
+COMBINED_FEATURES[vardeps] += "DISTRO_FEATURES MACHINE_FEATURES"
# Make sure MACHINE isn't exported
--
1.7.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] bitbake.conf: add a couple explicit vardeps
2011-11-16 21:17 [PATCH 1/2] bitbake.conf: add a couple explicit vardeps Chris Larson
@ 2011-11-18 14:29 ` Richard Purdie
2011-11-18 15:36 ` Chris Larson
0 siblings, 1 reply; 3+ messages in thread
From: Richard Purdie @ 2011-11-18 14:29 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Wed, 2011-11-16 at 14:17 -0700, Chris Larson wrote:
> Signed-off-by: Christopher Larson <chris_larson@mentor.com>
> ---
> meta/conf/bitbake.conf | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 0d6b3b8..c158c61 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -506,6 +506,7 @@ DEBUG_FLAGS ?= "-g -feliminate-unused-debug-types"
> FULL_OPTIMIZATION = "-O2 -pipe ${DEBUG_FLAGS}"
> DEBUG_OPTIMIZATION = "-O -fno-omit-frame-pointer ${DEBUG_FLAGS} -pipe"
> SELECTED_OPTIMIZATION = "${@bb.data.getVar(['FULL_OPTIMIZATION',
> 'DEBUG_OPTIMIZATION'][d.getVar('DEBUG_BUILD', 1) == '1'], d, 1)}"
> +SELECTED_OPTIMIZATION[vardeps] += "FULL_OPTIMIZATION DEBUG_OPTIMIZATION"
> BUILD_OPTIMIZATION = "-O2 -pipe"
>
> ##################################################################
> @@ -717,6 +718,7 @@ COMBINED_FEATURES = "\
> ${@base_both_contain("DISTRO_FEATURES", "MACHINE_FEATURES",
> "usbgadget", d)} \
> ${@base_both_contain("DISTRO_FEATURES", "MACHINE_FEATURES",
> "usbhost", d)} \
> ${@base_both_contain("DISTRO_FEATURES", "MACHINE_FEATURES", "wifi", d)}"
> +COMBINED_FEATURES[vardeps] += "DISTRO_FEATURES MACHINE_FEATURES"
>
>
> # Make sure MACHINE isn't exported
I merged this to master but your patch was line wrapped so I had to
unmangle it...
Cheers,
Richard
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] bitbake.conf: add a couple explicit vardeps
2011-11-18 14:29 ` Richard Purdie
@ 2011-11-18 15:36 ` Chris Larson
0 siblings, 0 replies; 3+ messages in thread
From: Chris Larson @ 2011-11-18 15:36 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Fri, Nov 18, 2011 at 7:29 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Wed, 2011-11-16 at 14:17 -0700, Chris Larson wrote:
>> Signed-off-by: Christopher Larson <chris_larson@mentor.com>
>> ---
>> meta/conf/bitbake.conf | 2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
>> index 0d6b3b8..c158c61 100644
>> --- a/meta/conf/bitbake.conf
>> +++ b/meta/conf/bitbake.conf
>> @@ -506,6 +506,7 @@ DEBUG_FLAGS ?= "-g -feliminate-unused-debug-types"
>> FULL_OPTIMIZATION = "-O2 -pipe ${DEBUG_FLAGS}"
>> DEBUG_OPTIMIZATION = "-O -fno-omit-frame-pointer ${DEBUG_FLAGS} -pipe"
>> SELECTED_OPTIMIZATION = "${@bb.data.getVar(['FULL_OPTIMIZATION',
>> 'DEBUG_OPTIMIZATION'][d.getVar('DEBUG_BUILD', 1) == '1'], d, 1)}"
>> +SELECTED_OPTIMIZATION[vardeps] += "FULL_OPTIMIZATION DEBUG_OPTIMIZATION"
>> BUILD_OPTIMIZATION = "-O2 -pipe"
>>
>> ##################################################################
>> @@ -717,6 +718,7 @@ COMBINED_FEATURES = "\
>> ${@base_both_contain("DISTRO_FEATURES", "MACHINE_FEATURES",
>> "usbgadget", d)} \
>> ${@base_both_contain("DISTRO_FEATURES", "MACHINE_FEATURES",
>> "usbhost", d)} \
>> ${@base_both_contain("DISTRO_FEATURES", "MACHINE_FEATURES", "wifi", d)}"
>> +COMBINED_FEATURES[vardeps] += "DISTRO_FEATURES MACHINE_FEATURES"
>>
>>
>> # Make sure MACHINE isn't exported
>
> I merged this to master but your patch was line wrapped so I had to
> unmangle it...
Yeah, sorry about that. I was getting an inexplicable error from
send-email, so used imap-send, but forgot that the gmail web interface
line wraps (stupid thing, they need to add an option to disable that).
--
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-18 15:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-16 21:17 [PATCH 1/2] bitbake.conf: add a couple explicit vardeps Chris Larson
2011-11-18 14:29 ` Richard Purdie
2011-11-18 15:36 ` Chris Larson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.