* [PATCH 1/2] ASoC: cs42l73: Return proper error code if device id mismatch
@ 2011-11-19 2:15 Axel Lin
2011-11-19 2:17 ` [PATCH 2/2] ASoC: cs42l73: Show correct revision id Axel Lin
2011-11-21 17:06 ` [PATCH 1/2] ASoC: cs42l73: Return proper error code if device id mismatch Mark Brown
0 siblings, 2 replies; 4+ messages in thread
From: Axel Lin @ 2011-11-19 2:15 UTC (permalink / raw)
To: alsa-devel
Cc: Vinod Koul, Liam Girdwood, Mark Brown, Brian Austin, Georgi Vlaev
Return -ENODEV instead of 0 if device id mismatch.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/codecs/cs42l73.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/soc/codecs/cs42l73.c b/sound/soc/codecs/cs42l73.c
index aadfd6b..3eed21e 100644
--- a/sound/soc/codecs/cs42l73.c
+++ b/sound/soc/codecs/cs42l73.c
@@ -1370,6 +1370,7 @@ static __devinit int cs42l73_i2c_probe(struct i2c_client *i2c_client,
if (devid != CS42L73_DEVID) {
+ ret = -ENODEV;
dev_err(&i2c_client->dev,
"CS42L73 Device ID (%X). Expected %X\n",
devid, CS42L73_DEVID);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] ASoC: cs42l73: Show correct revision id
2011-11-19 2:15 [PATCH 1/2] ASoC: cs42l73: Return proper error code if device id mismatch Axel Lin
@ 2011-11-19 2:17 ` Axel Lin
2011-11-21 17:06 ` Mark Brown
2011-11-21 17:06 ` [PATCH 1/2] ASoC: cs42l73: Return proper error code if device id mismatch Mark Brown
1 sibling, 1 reply; 4+ messages in thread
From: Axel Lin @ 2011-11-19 2:17 UTC (permalink / raw)
To: alsa-devel
Cc: Vinod Koul, Liam Girdwood, Mark Brown, Brian Austin, Georgi Vlaev
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/codecs/cs42l73.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/cs42l73.c b/sound/soc/codecs/cs42l73.c
index 3eed21e..066d869 100644
--- a/sound/soc/codecs/cs42l73.c
+++ b/sound/soc/codecs/cs42l73.c
@@ -1384,7 +1384,7 @@ static __devinit int cs42l73_i2c_probe(struct i2c_client *i2c_client,
}
dev_info(&i2c_client->dev,
- "Cirrus Logic CS42L73, Revision: %02X\n", ret & 0xFF);
+ "Cirrus Logic CS42L73, Revision: %02X\n", reg & 0xFF);
regcache_cache_only(cs42l73->regmap, true);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] ASoC: cs42l73: Return proper error code if device id mismatch
2011-11-19 2:15 [PATCH 1/2] ASoC: cs42l73: Return proper error code if device id mismatch Axel Lin
2011-11-19 2:17 ` [PATCH 2/2] ASoC: cs42l73: Show correct revision id Axel Lin
@ 2011-11-21 17:06 ` Mark Brown
1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2011-11-21 17:06 UTC (permalink / raw)
To: Axel Lin
Cc: Brian Austin, alsa-devel, Liam Girdwood, Vinod Koul, Georgi Vlaev
On Sat, Nov 19, 2011 at 10:15:53AM +0800, Axel Lin wrote:
> Return -ENODEV instead of 0 if device id mismatch.
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-11-21 17:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-19 2:15 [PATCH 1/2] ASoC: cs42l73: Return proper error code if device id mismatch Axel Lin
2011-11-19 2:17 ` [PATCH 2/2] ASoC: cs42l73: Show correct revision id Axel Lin
2011-11-21 17:06 ` Mark Brown
2011-11-21 17:06 ` [PATCH 1/2] ASoC: cs42l73: Return proper error code if device id mismatch Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.