From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Tanmay Inamdar <tinamdar@apm.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: powerpc: dts: Fix canyonlands EMAC interrupt map
Date: Wed, 23 Nov 2011 08:16:40 +1100 [thread overview]
Message-ID: <1321996600.14573.0.camel@pasglop> (raw)
In-Reply-To: <1321945877-22802-1-git-send-email-tinamdar@apm.com>
On Tue, 2011-11-22 at 12:41 +0530, Tanmay Inamdar wrote:
> Fixing interrupt mapping of EMAC for canyonlands
The previous stuff was odd .... but was it broken ?
It was done this way because the EMAC actually has more interrupts than
that which are routed to different UICs, and so doing a local map this
way allows to target multiple parents.
Cheers,
Ben.
> Signed-off-by: Tanmay Inamdar <tinamdar@apm.com>
> ---
> arch/powerpc/boot/dts/canyonlands.dts | 16 ++++++----------
> 1 files changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/canyonlands.dts b/arch/powerpc/boot/dts/canyonlands.dts
> index 3dc75de..c76bbcd 100644
> --- a/arch/powerpc/boot/dts/canyonlands.dts
> +++ b/arch/powerpc/boot/dts/canyonlands.dts
> @@ -360,13 +360,11 @@
> EMAC0: ethernet@ef600e00 {
> device_type = "network";
> compatible = "ibm,emac-460ex", "ibm,emac4sync";
> - interrupt-parent = <&EMAC0>;
> - interrupts = <0x0 0x1>;
> - #interrupt-cells = <1>;
> + interrupt-parent = <&UIC2>;
> #address-cells = <0>;
> #size-cells = <0>;
> - interrupt-map = </*Status*/ 0x0 &UIC2 0x10 0x4
> - /*Wake*/ 0x1 &UIC2 0x14 0x4>;
> + interrupts = </*Status*/0x10 0x4
> + /*Wake*/0x14 0x4>;
> reg = <0xef600e00 0x000000c4>;
> local-mac-address = [000000000000]; /* Filled in by U-Boot */
> mal-device = <&MAL0>;
> @@ -390,13 +388,11 @@
> EMAC1: ethernet@ef600f00 {
> device_type = "network";
> compatible = "ibm,emac-460ex", "ibm,emac4sync";
> - interrupt-parent = <&EMAC1>;
> - interrupts = <0x0 0x1>;
> - #interrupt-cells = <1>;
> + interrupt-parent = <&UIC2>;
> #address-cells = <0>;
> #size-cells = <0>;
> - interrupt-map = </*Status*/ 0x0 &UIC2 0x11 0x4
> - /*Wake*/ 0x1 &UIC2 0x15 0x4>;
> + interrupts = </*Status*/0x11 0x4
> + /*Wake*/0x15 0x4>;
> reg = <0xef600f00 0x000000c4>;
> local-mac-address = [000000000000]; /* Filled in by U-Boot */
> mal-device = <&MAL0>;
next prev parent reply other threads:[~2011-11-22 21:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 7:11 powerpc: dts: Fix canyonlands EMAC interrupt map Tanmay Inamdar
2011-11-22 11:30 ` Josh Boyer
2011-11-22 11:30 ` Josh Boyer
2011-11-22 14:15 ` Tanmay Inamdar
2011-11-22 14:31 ` Josh Boyer
2011-11-22 14:31 ` Josh Boyer
2011-11-22 22:05 ` Benjamin Herrenschmidt
2011-11-22 22:05 ` Benjamin Herrenschmidt
2011-11-22 21:16 ` Benjamin Herrenschmidt [this message]
2011-11-23 1:15 ` David Gibson
2011-11-23 1:15 ` David Gibson
2011-11-23 1:42 ` Benjamin Herrenschmidt
2011-11-23 1:42 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321996600.14573.0.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=tinamdar@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.