From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: linuxppc-dev@lists.ozlabs.org, Tanmay Inamdar <tinamdar@apm.com>,
linux-kernel@vger.kernel.org
Subject: Re: powerpc: dts: Fix canyonlands EMAC interrupt map
Date: Wed, 23 Nov 2011 12:42:18 +1100 [thread overview]
Message-ID: <1322012538.14573.20.camel@pasglop> (raw)
In-Reply-To: <20111123011517.GA5183@truffala.fritz.box>
On Wed, 2011-11-23 at 12:15 +1100, David Gibson wrote:
> On Wed, Nov 23, 2011 at 08:16:40AM +1100, Benjamin Herrenschmidt wrote:
> > On Tue, 2011-11-22 at 12:41 +0530, Tanmay Inamdar wrote:
> > > Fixing interrupt mapping of EMAC for canyonlands
> >
> > The previous stuff was odd .... but was it broken ?
> >
> > It was done this way because the EMAC actually has more interrupts than
> > that which are routed to different UICs, and so doing a local map this
> > way allows to target multiple parents.
>
> Well, in the canyonlands case, it appears that the interrupts went to
> the same pic, so the simpler representation should be correct as
> well. However, there certainly are boards where they go to multiple
> pics, so we need this interrupt-map trick.
Doesn't emac has something like 4 more interrupts that we simply haven't
been bothered wiring up (because we don't use them ?)
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: Tanmay Inamdar <tinamdar@apm.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: powerpc: dts: Fix canyonlands EMAC interrupt map
Date: Wed, 23 Nov 2011 12:42:18 +1100 [thread overview]
Message-ID: <1322012538.14573.20.camel@pasglop> (raw)
In-Reply-To: <20111123011517.GA5183@truffala.fritz.box>
On Wed, 2011-11-23 at 12:15 +1100, David Gibson wrote:
> On Wed, Nov 23, 2011 at 08:16:40AM +1100, Benjamin Herrenschmidt wrote:
> > On Tue, 2011-11-22 at 12:41 +0530, Tanmay Inamdar wrote:
> > > Fixing interrupt mapping of EMAC for canyonlands
> >
> > The previous stuff was odd .... but was it broken ?
> >
> > It was done this way because the EMAC actually has more interrupts than
> > that which are routed to different UICs, and so doing a local map this
> > way allows to target multiple parents.
>
> Well, in the canyonlands case, it appears that the interrupts went to
> the same pic, so the simpler representation should be correct as
> well. However, there certainly are boards where they go to multiple
> pics, so we need this interrupt-map trick.
Doesn't emac has something like 4 more interrupts that we simply haven't
been bothered wiring up (because we don't use them ?)
Cheers,
Ben.
next prev parent reply other threads:[~2011-11-23 1:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 7:11 powerpc: dts: Fix canyonlands EMAC interrupt map Tanmay Inamdar
2011-11-22 11:30 ` Josh Boyer
2011-11-22 11:30 ` Josh Boyer
2011-11-22 14:15 ` Tanmay Inamdar
2011-11-22 14:31 ` Josh Boyer
2011-11-22 14:31 ` Josh Boyer
2011-11-22 22:05 ` Benjamin Herrenschmidt
2011-11-22 22:05 ` Benjamin Herrenschmidt
2011-11-22 21:16 ` Benjamin Herrenschmidt
2011-11-23 1:15 ` David Gibson
2011-11-23 1:15 ` David Gibson
2011-11-23 1:42 ` Benjamin Herrenschmidt [this message]
2011-11-23 1:42 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322012538.14573.20.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=tinamdar@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.