All of lore.kernel.org
 help / color / mirror / Atom feed
From: John F Leach <jfleach@jfleach.com>
To: Daniel Mack <zonque@gmail.com>
Cc: tiwai@suse.de, alsa-devel <alsa-devel@alsa-project.org>,
	clemens <clemens@ladisch.de>
Subject: Re: [PATCH] [ALSA] usb-audio - Support for Roland GAIA SH-01 Synthesizer
Date: Sun, 27 Nov 2011 11:10:27 -0500	[thread overview]
Message-ID: <1322410227.14597.19.camel@darkside> (raw)
In-Reply-To: <4ED25560.40208@gmail.com>

> Entries in this list should be ordered by the USB vendor/product ID,
> which is not the case judging from the next block:
> 
> >  	/* Roland SH-201 */
> >  	USB_DEVICE(0x0582, 0x00ad),
> >  	.driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) {
> 
> 
> Otherwise looks good.
> 
> Thanks for sending patches!
> 
> 
> Daniel

Thanks for the feedback Daniel; I submitted a revised patch with the
correct list order and fixed the wrapped line for the driver_info.

Regards,

John F Leach   

  parent reply	other threads:[~2011-11-27 16:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-27 14:34 [PATCH] [ALSA] usb-audio - Support for Roland GAIA SH-01 Synthesizer John F Leach
2011-11-27 15:21 ` Daniel Mack
2011-11-27 16:03   ` [PATCH] [ALSA] usb-audio - Support for Roland GAIA SH-01 Synthesizer - fix list order and wrapped line John F Leach
2011-11-27 16:10   ` John F Leach [this message]
2011-11-27 16:42     ` [PATCH] [ALSA] usb-audio - Support for Roland GAIA SH-01 Synthesizer Daniel Mack
2011-11-27 17:39       ` Takashi Iwai
2011-11-27 22:15         ` John F Leach
2011-11-28  9:48           ` Takashi Iwai
2011-11-29  0:41             ` John F Leach
2011-11-29  7:24               ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1322410227.14597.19.camel@darkside \
    --to=jfleach@jfleach.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=clemens@ladisch.de \
    --cc=tiwai@suse.de \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.