Re: [PATCH] [ALSA] usb-audio - Support for Roland GAIA SH-01 Synthesizer

[Daniel Mack <zonque@gmail.com>]

On 11/27/2011 05:10 PM, John F Leach wrote:
>> Entries in this list should be ordered by the USB vendor/product ID,
>> which is not the case judging from the next block:
>>
>>>  	/* Roland SH-201 */
>>>  	USB_DEVICE(0x0582, 0x00ad),
>>>  	.driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) {
>>
>>
>> Otherwise looks good.
>>
>> Thanks for sending patches!
>>
>>
>> Daniel
> 
> Thanks for the feedback Daniel; I submitted a revised patch with the
> correct list order and fixed the wrapped line for the driver_info.

Nice. The only thing worth mentioning here is that your "change log"
shouldn't be placed in the mail subject (which will be the patch
headline eventually). Next time, just put things you don't want to be
part of the actual patch itself underneath the "---" line below the
diffstat.

But I think this time, Takashi can fix it up when commiting? :)


Daniel