All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] pulseaudio 1.1: convert to useradd.bbclass
@ 2011-12-01 10:48 Koen Kooi
  2011-12-01 10:48 ` [PATCH 2/2] pulseaudio 1.1: add filter-apply and filter-heuristics to pulseaudio-server RDEPENDS, it won't start without Koen Kooi
  2011-12-01 10:53 ` [PATCH 1/2] pulseaudio 1.1: convert to useradd.bbclass Richard Purdie
  0 siblings, 2 replies; 3+ messages in thread
From: Koen Kooi @ 2011-12-01 10:48 UTC (permalink / raw)
  To: openembedded-core; +Cc: Koen Kooi

The only thing that got lost in the conversion is the "Pulse Audio daemon" description:

root@beagleboard:~# grep pulse /etc/passwd /etc/group
/etc/passwd:pulse:x:999:1000::/var/run/pulse:/bin/false
/etc/group:audio:x:29:pulse
/etc/group:pulse:x:1000:pulse

Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
---
 meta/recipes-multimedia/pulseaudio/pulseaudio.inc |   18 ++++++++----------
 1 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
index 131d659..4170857 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
@@ -16,7 +16,7 @@ SRC_URI = "http://0pointer.de/lennart/projects/pulseaudio/pulseaudio-${PV}.tar.g
            file://gcc4-compile-fix.patch \
            file://volatiles.04_pulse"
 
-inherit autotools pkgconfig
+inherit autotools pkgconfig useradd
 
 EXTRA_OECONF = "\
 		--disable-lynx \
@@ -50,6 +50,12 @@ do_install_append() {
 	fi
 }
 
+USERADD_PACKAGES = "pulseaudio-server"
+GROUPADD_PARAM_pulseaudio-server = "pulse"
+USERADD_PARAM_pulseaudio-server = "--system --home /var/run/pulse \
+                              --no-create-home --shell /bin/false \
+                              --groups audio,pulse --gid pulse pulse"
+
 PACKAGES =+ "libpulsecore libpulsecommon libpulsedsp libpulse libpulse-simple libpulse-browse libpulse-mainloop-glib \
              pulseaudio-server pulseaudio-misc pulseaudio-gconf-helper"
 
@@ -90,20 +96,12 @@ pkg_postinst_${PN}-server() {
         if [ "x$D" != "x" ]; then
                 exit 1
         fi
-        grep -q pulse: ${sysconfdir}/group || addgroup pulse
-        grep -q pulse: ${sysconfdir}/passwd || \
-            adduser --disabled-password --home=/var/run/pulse --system \
-                    --ingroup pulse --no-create-home -g "Pulse audio daemon" pulse
-        addgroup pulse audio
+
         if [ -e ${sysconfdir}/init.d/populate-volatile.sh ] ; then
             ${sysconfdir}/init.d/populate-volatile.sh update
         fi
 }
 
-pkg_postrm_${PN}-server() {
-        deluser pulse || true
-}
-
 python populate_packages_prepend() {
         #d.setVar('PKG_pulseaudio', 'pulseaudio')
 
-- 
1.7.2.5




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] pulseaudio 1.1: add filter-apply and filter-heuristics to pulseaudio-server RDEPENDS, it won't start without
  2011-12-01 10:48 [PATCH 1/2] pulseaudio 1.1: convert to useradd.bbclass Koen Kooi
@ 2011-12-01 10:48 ` Koen Kooi
  2011-12-01 10:53 ` [PATCH 1/2] pulseaudio 1.1: convert to useradd.bbclass Richard Purdie
  1 sibling, 0 replies; 3+ messages in thread
From: Koen Kooi @ 2011-12-01 10:48 UTC (permalink / raw)
  To: openembedded-core; +Cc: Koen Kooi

Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
---
 meta/recipes-multimedia/pulseaudio/pulseaudio.inc  |    2 ++
 .../pulseaudio/pulseaudio_1.1.bb                   |    2 +-
 2 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
index 4170857..38ecba5 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
@@ -112,6 +112,8 @@ python populate_packages_prepend() {
 
 RDEPENDS_pulseaudio-module-console-kit =+ "consolekit"
 RDEPENDS_pulseaudio-server = " \
+    pulseaudio-module-filter-apply \
+    pulseaudio-module-filter-heuristics \
     pulseaudio-module-udev-detect \
     pulseaudio-module-null-sink \
     pulseaudio-module-device-restore \
diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio_1.1.bb b/meta/recipes-multimedia/pulseaudio/pulseaudio_1.1.bb
index 7fa5799..4c8b46f 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio_1.1.bb
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_1.1.bb
@@ -1,6 +1,6 @@
 require pulseaudio.inc
 
-PR = "r3"
+PR = "r4"
 
 DEPENDS += "libjson gdbm speex libxml-parser-perl-native"
 
-- 
1.7.2.5




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] pulseaudio 1.1: convert to useradd.bbclass
  2011-12-01 10:48 [PATCH 1/2] pulseaudio 1.1: convert to useradd.bbclass Koen Kooi
  2011-12-01 10:48 ` [PATCH 2/2] pulseaudio 1.1: add filter-apply and filter-heuristics to pulseaudio-server RDEPENDS, it won't start without Koen Kooi
@ 2011-12-01 10:53 ` Richard Purdie
  1 sibling, 0 replies; 3+ messages in thread
From: Richard Purdie @ 2011-12-01 10:53 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer; +Cc: Koen Kooi

On Thu, 2011-12-01 at 11:48 +0100, Koen Kooi wrote:
> The only thing that got lost in the conversion is the "Pulse Audio daemon" description:
> 
> root@beagleboard:~# grep pulse /etc/passwd /etc/group
> /etc/passwd:pulse:x:999:1000::/var/run/pulse:/bin/false
> /etc/group:audio:x:29:pulse
> /etc/group:pulse:x:1000:pulse
> 
> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> ---
>  meta/recipes-multimedia/pulseaudio/pulseaudio.inc |   18 ++++++++----------
>  1 files changed, 8 insertions(+), 10 deletions(-)

Merged to master (along with 2/2), thanks.

Richard




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-12-01 11:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-01 10:48 [PATCH 1/2] pulseaudio 1.1: convert to useradd.bbclass Koen Kooi
2011-12-01 10:48 ` [PATCH 2/2] pulseaudio 1.1: add filter-apply and filter-heuristics to pulseaudio-server RDEPENDS, it won't start without Koen Kooi
2011-12-01 10:53 ` [PATCH 1/2] pulseaudio 1.1: convert to useradd.bbclass Richard Purdie

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.