* [PATCH] wl12xx: Restore testmode ABI
@ 2011-12-01 11:13 Pontus Fuchs
2011-12-01 11:23 ` Kalle Valo
2011-12-15 8:53 ` Luciano Coelho
0 siblings, 2 replies; 4+ messages in thread
From: Pontus Fuchs @ 2011-12-01 11:13 UTC (permalink / raw)
To: coelho; +Cc: linux-wireless
Commit 80900d0140a7648587982c8f299830e900e49165 accidently broke
the ABI for testmode commands. Restore the ABI again.
Signed-off-by: Pontus Fuchs <pontus.fuchs@gmail.com>
Cc: stable@kernel.org
---
drivers/net/wireless/wl12xx/testmode.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/wl12xx/testmode.c b/drivers/net/wireless/wl12xx/testmode.c
index 61fff45..5b3f781 100644
--- a/drivers/net/wireless/wl12xx/testmode.c
+++ b/drivers/net/wireless/wl12xx/testmode.c
@@ -37,6 +37,7 @@ enum wl1271_tm_commands {
WL1271_TM_CMD_TEST,
WL1271_TM_CMD_INTERROGATE,
WL1271_TM_CMD_CONFIGURE,
+ WL1271_TM_CMD_NVS_PUSH, /* Not in use. Keep to not break ABI */
WL1271_TM_CMD_SET_PLT_MODE,
WL1271_TM_CMD_RECOVER,
--
1.7.5.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] wl12xx: Restore testmode ABI
2011-12-01 11:13 [PATCH] wl12xx: Restore testmode ABI Pontus Fuchs
@ 2011-12-01 11:23 ` Kalle Valo
2011-12-15 7:37 ` Luciano Coelho
2011-12-15 8:53 ` Luciano Coelho
1 sibling, 1 reply; 4+ messages in thread
From: Kalle Valo @ 2011-12-01 11:23 UTC (permalink / raw)
To: Pontus Fuchs; +Cc: coelho, linux-wireless
Pontus Fuchs <pontus.fuchs@gmail.com> writes:
> Commit 80900d0140a7648587982c8f299830e900e49165 accidently broke
> the ABI for testmode commands. Restore the ABI again.
>
[...]
> --- a/drivers/net/wireless/wl12xx/testmode.c
> +++ b/drivers/net/wireless/wl12xx/testmode.c
> @@ -37,6 +37,7 @@ enum wl1271_tm_commands {
> WL1271_TM_CMD_TEST,
> WL1271_TM_CMD_INTERROGATE,
> WL1271_TM_CMD_CONFIGURE,
> + WL1271_TM_CMD_NVS_PUSH, /* Not in use. Keep to not break ABI */
Better to call it WL1271_TM_CMD_UNUSED1, or something like that, so that
it really stays unused.
--
Kalle Valo
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] wl12xx: Restore testmode ABI
2011-12-01 11:23 ` Kalle Valo
@ 2011-12-15 7:37 ` Luciano Coelho
0 siblings, 0 replies; 4+ messages in thread
From: Luciano Coelho @ 2011-12-15 7:37 UTC (permalink / raw)
To: Kalle Valo; +Cc: Pontus Fuchs, linux-wireless
Hi Kalle,
On Thu, 2011-12-01 at 13:23 +0200, Kalle Valo wrote:
> Pontus Fuchs <pontus.fuchs@gmail.com> writes:
>
> > Commit 80900d0140a7648587982c8f299830e900e49165 accidently broke
> > the ABI for testmode commands. Restore the ABI again.
> >
>
> [...]
>
> > --- a/drivers/net/wireless/wl12xx/testmode.c
> > +++ b/drivers/net/wireless/wl12xx/testmode.c
> > @@ -37,6 +37,7 @@ enum wl1271_tm_commands {
> > WL1271_TM_CMD_TEST,
> > WL1271_TM_CMD_INTERROGATE,
> > WL1271_TM_CMD_CONFIGURE,
> > + WL1271_TM_CMD_NVS_PUSH, /* Not in use. Keep to not break ABI */
>
> Better to call it WL1271_TM_CMD_UNUSED1, or something like that, so that
> it really stays unused.
As we discussed briefly on IRC, I think it's a better idea to keep it as
is. If anyone still uses it (despite the comment saying it's not in
use), we will return -EOPNOTSUPP.
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] wl12xx: Restore testmode ABI
2011-12-01 11:13 [PATCH] wl12xx: Restore testmode ABI Pontus Fuchs
2011-12-01 11:23 ` Kalle Valo
@ 2011-12-15 8:53 ` Luciano Coelho
1 sibling, 0 replies; 4+ messages in thread
From: Luciano Coelho @ 2011-12-15 8:53 UTC (permalink / raw)
To: Pontus Fuchs; +Cc: linux-wireless
On Thu, 2011-12-01 at 12:13 +0100, Pontus Fuchs wrote:
> Commit 80900d0140a7648587982c8f299830e900e49165 accidently broke
> the ABI for testmode commands. Restore the ABI again.
>
> Signed-off-by: Pontus Fuchs <pontus.fuchs@gmail.com>
> Cc: stable@kernel.org
> ---
Applied, thanks!
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-12-15 8:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-01 11:13 [PATCH] wl12xx: Restore testmode ABI Pontus Fuchs
2011-12-01 11:23 ` Kalle Valo
2011-12-15 7:37 ` Luciano Coelho
2011-12-15 8:53 ` Luciano Coelho
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.