* Re: iwlwifi: kernel panic if try to open tid with large index (>=8)
2011-12-02 4:29 iwlwifi: kernel panic if try to open tid with large index (>=8) Nikolay Martynov
@ 2011-12-02 3:42 ` Guy, Wey-Yi
2011-12-02 9:11 ` Johannes Berg
1 sibling, 0 replies; 6+ messages in thread
From: Guy, Wey-Yi @ 2011-12-02 3:42 UTC (permalink / raw)
To: Nikolay Martynov; +Cc: linux-wireless@vger.kernel.org
hmm, this is a good catch, I don't believe anyone here ever test with
this. Thank you so much for letting us know.
Wey
On Thu, 2011-12-01 at 20:29 -0800, Nikolay Martynov wrote:
> Hi.
>
> I have an intel 5300 card running on latest compat-wireless.
> If I do:
> echo "tx start 8" >
> /sys/kernel/debug/ieee80211/phy0/netdev\:wlan1/stations/XX\:XX\:XX\:XX\:XX\:XX/agg_status
> I get two pages of kernel stack trace and complete freeze, no
> messages left in any logs after reboot.
> I looks like driver doesn't correctly check that this tid is
> actually supported when it comes from mac80211 layer.
> This doesn't seem like a huge issue, just an annoying one.
>
> Please let me knoe if I can provide any more information.
> Thanks.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* iwlwifi: kernel panic if try to open tid with large index (>=8)
@ 2011-12-02 4:29 Nikolay Martynov
2011-12-02 3:42 ` Guy, Wey-Yi
2011-12-02 9:11 ` Johannes Berg
0 siblings, 2 replies; 6+ messages in thread
From: Nikolay Martynov @ 2011-12-02 4:29 UTC (permalink / raw)
To: linux-wireless
Hi.
I have an intel 5300 card running on latest compat-wireless.
If I do:
echo "tx start 8" >
/sys/kernel/debug/ieee80211/phy0/netdev\:wlan1/stations/XX\:XX\:XX\:XX\:XX\:XX/agg_status
I get two pages of kernel stack trace and complete freeze, no
messages left in any logs after reboot.
I looks like driver doesn't correctly check that this tid is
actually supported when it comes from mac80211 layer.
This doesn't seem like a huge issue, just an annoying one.
Please let me knoe if I can provide any more information.
Thanks.
--
Truthfully yours,
Martynov Nikolay.
Email: mar.kolya@gmail.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: iwlwifi: kernel panic if try to open tid with large index (>=8)
2011-12-02 4:29 iwlwifi: kernel panic if try to open tid with large index (>=8) Nikolay Martynov
2011-12-02 3:42 ` Guy, Wey-Yi
@ 2011-12-02 9:11 ` Johannes Berg
2011-12-02 15:01 ` wwguy
1 sibling, 1 reply; 6+ messages in thread
From: Johannes Berg @ 2011-12-02 9:11 UTC (permalink / raw)
To: Nikolay Martynov; +Cc: linux-wireless
On Thu, 2011-12-01 at 23:29 -0500, Nikolay Martynov wrote:
> Hi.
>
> I have an intel 5300 card running on latest compat-wireless.
> If I do:
> echo "tx start 8" >
> /sys/kernel/debug/ieee80211/phy0/netdev\:wlan1/stations/XX\:XX\:XX\:XX\:XX\:XX/agg_status
Yikes. I think mac80211 should just reject that since it will never put
traffic into that TID anyway.
johannes
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: iwlwifi: kernel panic if try to open tid with large index (>=8)
2011-12-02 9:11 ` Johannes Berg
@ 2011-12-02 15:01 ` wwguy
2011-12-02 20:19 ` Johannes Berg
0 siblings, 1 reply; 6+ messages in thread
From: wwguy @ 2011-12-02 15:01 UTC (permalink / raw)
To: Johannes Berg; +Cc: Nikolay Martynov, linux-wireless@vger.kernel.org
On Fri, 2011-12-02 at 01:11 -0800, Johannes Berg wrote:
> On Thu, 2011-12-01 at 23:29 -0500, Nikolay Martynov wrote:
> > Hi.
> >
> > I have an intel 5300 card running on latest compat-wireless.
> > If I do:
> > echo "tx start 8" >
> > /sys/kernel/debug/ieee80211/phy0/netdev\:wlan1/stations/XX\:XX\:XX\:XX\:XX\:XX/agg_status
>
> Yikes. I think mac80211 should just reject that since it will never put
> traffic into that TID anyway.
>
Johannes, are you going to help fix that :-)
Wey
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: iwlwifi: kernel panic if try to open tid with large index (>=8)
2011-12-02 20:19 ` Johannes Berg
@ 2011-12-02 20:14 ` wwguy
0 siblings, 0 replies; 6+ messages in thread
From: wwguy @ 2011-12-02 20:14 UTC (permalink / raw)
To: Johannes Berg; +Cc: Nikolay Martynov, linux-wireless@vger.kernel.org
On Fri, 2011-12-02 at 12:19 -0800, Johannes Berg wrote:
> On Fri, 2011-12-02 at 07:01 -0800, wwguy wrote:
> > On Fri, 2011-12-02 at 01:11 -0800, Johannes Berg wrote:
> > > On Thu, 2011-12-01 at 23:29 -0500, Nikolay Martynov wrote:
> > > > Hi.
> > > >
> > > > I have an intel 5300 card running on latest compat-wireless.
> > > > If I do:
> > > > echo "tx start 8" >
> > > > /sys/kernel/debug/ieee80211/phy0/netdev\:wlan1/stations/XX\:XX\:XX\:XX\:XX\:XX/agg_status
> > >
> > > Yikes. I think mac80211 should just reject that since it will never put
> > > traffic into that TID anyway.
> > >
> > Johannes, are you going to help fix that :-)
>
> I *think* this is the right fix. Do you agree? It fixes it for sure --
> but does it really not have any side effects? I'm pretty sure it doesn't
> since I looked at all the code just now ...
>
initial look at it, I agree
Wey
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: iwlwifi: kernel panic if try to open tid with large index (>=8)
2011-12-02 15:01 ` wwguy
@ 2011-12-02 20:19 ` Johannes Berg
2011-12-02 20:14 ` wwguy
0 siblings, 1 reply; 6+ messages in thread
From: Johannes Berg @ 2011-12-02 20:19 UTC (permalink / raw)
To: wwguy; +Cc: Nikolay Martynov, linux-wireless@vger.kernel.org
On Fri, 2011-12-02 at 07:01 -0800, wwguy wrote:
> On Fri, 2011-12-02 at 01:11 -0800, Johannes Berg wrote:
> > On Thu, 2011-12-01 at 23:29 -0500, Nikolay Martynov wrote:
> > > Hi.
> > >
> > > I have an intel 5300 card running on latest compat-wireless.
> > > If I do:
> > > echo "tx start 8" >
> > > /sys/kernel/debug/ieee80211/phy0/netdev\:wlan1/stations/XX\:XX\:XX\:XX\:XX\:XX/agg_status
> >
> > Yikes. I think mac80211 should just reject that since it will never put
> > traffic into that TID anyway.
> >
> Johannes, are you going to help fix that :-)
I *think* this is the right fix. Do you agree? It fixes it for sure --
but does it really not have any side effects? I'm pretty sure it doesn't
since I looked at all the code just now ...
johannes
---
drivers/net/wireless/iwlwifi/iwl-commands.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/wireless/iwlwifi/iwl-commands.h 2011-12-02 21:12:01.000000000 +0100
+++ b/drivers/net/wireless/iwlwifi/iwl-commands.h 2011-12-02 21:12:02.000000000 +0100
@@ -814,7 +814,7 @@ struct iwl_qosparam_cmd {
#define IWLAGN_STATION_COUNT 16
#define IWL_INVALID_STATION 255
-#define IWL_MAX_TID_COUNT 9
+#define IWL_MAX_TID_COUNT 8
#define STA_FLG_TX_RATE_MSK cpu_to_le32(1 << 2)
#define STA_FLG_PWR_SAVE_MSK cpu_to_le32(1 << 8)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-12-02 20:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-02 4:29 iwlwifi: kernel panic if try to open tid with large index (>=8) Nikolay Martynov
2011-12-02 3:42 ` Guy, Wey-Yi
2011-12-02 9:11 ` Johannes Berg
2011-12-02 15:01 ` wwguy
2011-12-02 20:19 ` Johannes Berg
2011-12-02 20:14 ` wwguy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.