All of lore.kernel.org
 help / color / mirror / Atom feed
From: tixy@yxit.co.uk (Tixy)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC][PATCH] ARM: kirkwood: Remove eSATA SheevaPlug board support
Date: Tue, 06 Dec 2011 07:07:08 +0000	[thread overview]
Message-ID: <1323155228.2237.10.camel@computer2> (raw)
In-Reply-To: <alpine.LFD.2.02.1112031247230.2357@xanadu.home>

On Sat, 2011-12-03 at 13:00 -0500, Nicolas Pitre wrote:
> On Sat, 3 Dec 2011, Tixy wrote:
> > [PATCH] Fix machine_is_xxx() naming for eSata SheevaPlug and QNAP TS-209
> > 
> > The eSata SheevaPlug and QNAP TS-209 devices were removed from
> > mach-types due to naming mismatches between machine_is_xxx(), CONFIG_XXX
> > and MACH_TYPE_XXX.
> > 
> > This patch fixes those mismatches and adds the devices back into
> > mach-types.
> > 
> > Cc: Nicolas Pitre <nico@fluxnic.net>
> > Cc: Lennert Buytenhek <kernel@wantstofly.org>
> > Cc: Russell King <linux@arm.linux.org.uk>
> > Signed-off-by: Jon Medhurst <tixy@yxit.co.uk>
> 
> Acked-by: Nicolas Pitre <nico@linaro.org>
> 
> Obviously, the change to mach-types should be done in the machine 
> registry database as well by RMK.

Which tree should this go through? Russell's or arm-soc?

-- 
Tixy

> > ---
> >  arch/arm/mach-kirkwood/sheevaplug-setup.c |    6 +++---
> >  arch/arm/mach-orion5x/ts209-setup.c       |    2 +-
> >  arch/arm/tools/mach-types                 |    2 ++
> >  3 files changed, 6 insertions(+), 4 deletions(-)
> > 
> > diff --git a/arch/arm/mach-kirkwood/sheevaplug-setup.c b/arch/arm/mach-kirkwood/sheevaplug-setup.c
> > index 85bff6b..4ea70e5 100644
> > --- a/arch/arm/mach-kirkwood/sheevaplug-setup.c
> > +++ b/arch/arm/mach-kirkwood/sheevaplug-setup.c
> > @@ -107,7 +107,7 @@ static void __init sheevaplug_init(void)
> >  	kirkwood_init();
> >  
> >  	/* setup gpio pin select */
> > -	if (machine_is_sheeva_esata())
> > +	if (machine_is_esata_sheevaplug())
> >  		kirkwood_mpp_conf(sheeva_esata_mpp_config);
> >  	else
> >  		kirkwood_mpp_conf(sheevaplug_mpp_config);
> > @@ -123,11 +123,11 @@ static void __init sheevaplug_init(void)
> >  	kirkwood_ge00_init(&sheevaplug_ge00_data);
> >  
> >  	/* honor lower power consumption for plugs with out eSATA */
> > -	if (machine_is_sheeva_esata())
> > +	if (machine_is_esata_sheevaplug())
> >  		kirkwood_sata_init(&sheeva_esata_sata_data);
> >  
> >  	/* enable sd wp and sd cd on plugs with esata */
> > -	if (machine_is_sheeva_esata())
> > +	if (machine_is_esata_sheevaplug())
> >  		kirkwood_sdio_init(&sheeva_esata_mvsdio_data);
> >  	else
> >  		kirkwood_sdio_init(&sheevaplug_mvsdio_data);
> > diff --git a/arch/arm/mach-orion5x/ts209-setup.c b/arch/arm/mach-orion5x/ts209-setup.c
> > index 62c156b..5d64087 100644
> > --- a/arch/arm/mach-orion5x/ts209-setup.c
> > +++ b/arch/arm/mach-orion5x/ts209-setup.c
> > @@ -178,7 +178,7 @@ static struct hw_pci qnap_ts209_pci __initdata = {
> >  
> >  static int __init qnap_ts209_pci_init(void)
> >  {
> > -	if (machine_is_ts_x09())
> > +	if (machine_is_ts209())
> >  		pci_common_init(&qnap_ts209_pci);
> >  
> >  	return 0;
> > diff --git a/arch/arm/tools/mach-types b/arch/arm/tools/mach-types
> > index 459d114..7f9809a 100644
> > --- a/arch/arm/tools/mach-types
> > +++ b/arch/arm/tools/mach-types
> > @@ -269,6 +269,7 @@ dns323			MACH_DNS323		DNS323			1542
> >  omap3_beagle		MACH_OMAP3_BEAGLE	OMAP3_BEAGLE		1546
> >  nokia_n810		MACH_NOKIA_N810		NOKIA_N810		1548
> >  pcm038			MACH_PCM038		PCM038			1551
> > +ts209			MACH_TS209		TS209			1565
> >  at91cap9adk		MACH_AT91CAP9ADK	AT91CAP9ADK		1566
> >  mx31moboard		MACH_MX31MOBOARD	MX31MOBOARD		1574
> >  vision_ep9307		MACH_VISION_EP9307	VISION_EP9307		1578
> > @@ -457,6 +458,7 @@ guruplug		MACH_GURUPLUG		GURUPLUG		2659
> >  spear310		MACH_SPEAR310		SPEAR310		2660
> >  spear320		MACH_SPEAR320		SPEAR320		2661
> >  aquila			MACH_AQUILA		AQUILA			2676
> > +esata_sheevaplug	MACH_ESATA_SHEEVAPLUG	ESATA_SHEEVAPLUG	2678
> >  msm7x30_surf		MACH_MSM7X30_SURF	MSM7X30_SURF		2679
> >  ea2478devkit		MACH_EA2478DEVKIT	EA2478DEVKIT		2683
> >  terastation_wxl		MACH_TERASTATION_WXL	TERASTATION_WXL		2697
> > -- 
> > 1.7.2.5
> > 
> > 
> > 

WARNING: multiple messages have this Message-ID (diff)
From: Tixy <tixy@yxit.co.uk>
To: Nicolas Pitre <nico@fluxnic.net>
Cc: Axel Lin <axel.lin@gmail.com>,
	linux-kernel@vger.kernel.org,
	John Holland <john.holland@cellent-fs.de>,
	Russell King <linux@arm.linux.org.uk>,
	Lennert Buytenhek <kernel@wantstofly.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC][PATCH] ARM: kirkwood: Remove eSATA SheevaPlug board support
Date: Tue, 06 Dec 2011 07:07:08 +0000	[thread overview]
Message-ID: <1323155228.2237.10.camel@computer2> (raw)
In-Reply-To: <alpine.LFD.2.02.1112031247230.2357@xanadu.home>

On Sat, 2011-12-03 at 13:00 -0500, Nicolas Pitre wrote:
> On Sat, 3 Dec 2011, Tixy wrote:
> > [PATCH] Fix machine_is_xxx() naming for eSata SheevaPlug and QNAP TS-209
> > 
> > The eSata SheevaPlug and QNAP TS-209 devices were removed from
> > mach-types due to naming mismatches between machine_is_xxx(), CONFIG_XXX
> > and MACH_TYPE_XXX.
> > 
> > This patch fixes those mismatches and adds the devices back into
> > mach-types.
> > 
> > Cc: Nicolas Pitre <nico@fluxnic.net>
> > Cc: Lennert Buytenhek <kernel@wantstofly.org>
> > Cc: Russell King <linux@arm.linux.org.uk>
> > Signed-off-by: Jon Medhurst <tixy@yxit.co.uk>
> 
> Acked-by: Nicolas Pitre <nico@linaro.org>
> 
> Obviously, the change to mach-types should be done in the machine 
> registry database as well by RMK.

Which tree should this go through? Russell's or arm-soc?

-- 
Tixy

> > ---
> >  arch/arm/mach-kirkwood/sheevaplug-setup.c |    6 +++---
> >  arch/arm/mach-orion5x/ts209-setup.c       |    2 +-
> >  arch/arm/tools/mach-types                 |    2 ++
> >  3 files changed, 6 insertions(+), 4 deletions(-)
> > 
> > diff --git a/arch/arm/mach-kirkwood/sheevaplug-setup.c b/arch/arm/mach-kirkwood/sheevaplug-setup.c
> > index 85bff6b..4ea70e5 100644
> > --- a/arch/arm/mach-kirkwood/sheevaplug-setup.c
> > +++ b/arch/arm/mach-kirkwood/sheevaplug-setup.c
> > @@ -107,7 +107,7 @@ static void __init sheevaplug_init(void)
> >  	kirkwood_init();
> >  
> >  	/* setup gpio pin select */
> > -	if (machine_is_sheeva_esata())
> > +	if (machine_is_esata_sheevaplug())
> >  		kirkwood_mpp_conf(sheeva_esata_mpp_config);
> >  	else
> >  		kirkwood_mpp_conf(sheevaplug_mpp_config);
> > @@ -123,11 +123,11 @@ static void __init sheevaplug_init(void)
> >  	kirkwood_ge00_init(&sheevaplug_ge00_data);
> >  
> >  	/* honor lower power consumption for plugs with out eSATA */
> > -	if (machine_is_sheeva_esata())
> > +	if (machine_is_esata_sheevaplug())
> >  		kirkwood_sata_init(&sheeva_esata_sata_data);
> >  
> >  	/* enable sd wp and sd cd on plugs with esata */
> > -	if (machine_is_sheeva_esata())
> > +	if (machine_is_esata_sheevaplug())
> >  		kirkwood_sdio_init(&sheeva_esata_mvsdio_data);
> >  	else
> >  		kirkwood_sdio_init(&sheevaplug_mvsdio_data);
> > diff --git a/arch/arm/mach-orion5x/ts209-setup.c b/arch/arm/mach-orion5x/ts209-setup.c
> > index 62c156b..5d64087 100644
> > --- a/arch/arm/mach-orion5x/ts209-setup.c
> > +++ b/arch/arm/mach-orion5x/ts209-setup.c
> > @@ -178,7 +178,7 @@ static struct hw_pci qnap_ts209_pci __initdata = {
> >  
> >  static int __init qnap_ts209_pci_init(void)
> >  {
> > -	if (machine_is_ts_x09())
> > +	if (machine_is_ts209())
> >  		pci_common_init(&qnap_ts209_pci);
> >  
> >  	return 0;
> > diff --git a/arch/arm/tools/mach-types b/arch/arm/tools/mach-types
> > index 459d114..7f9809a 100644
> > --- a/arch/arm/tools/mach-types
> > +++ b/arch/arm/tools/mach-types
> > @@ -269,6 +269,7 @@ dns323			MACH_DNS323		DNS323			1542
> >  omap3_beagle		MACH_OMAP3_BEAGLE	OMAP3_BEAGLE		1546
> >  nokia_n810		MACH_NOKIA_N810		NOKIA_N810		1548
> >  pcm038			MACH_PCM038		PCM038			1551
> > +ts209			MACH_TS209		TS209			1565
> >  at91cap9adk		MACH_AT91CAP9ADK	AT91CAP9ADK		1566
> >  mx31moboard		MACH_MX31MOBOARD	MX31MOBOARD		1574
> >  vision_ep9307		MACH_VISION_EP9307	VISION_EP9307		1578
> > @@ -457,6 +458,7 @@ guruplug		MACH_GURUPLUG		GURUPLUG		2659
> >  spear310		MACH_SPEAR310		SPEAR310		2660
> >  spear320		MACH_SPEAR320		SPEAR320		2661
> >  aquila			MACH_AQUILA		AQUILA			2676
> > +esata_sheevaplug	MACH_ESATA_SHEEVAPLUG	ESATA_SHEEVAPLUG	2678
> >  msm7x30_surf		MACH_MSM7X30_SURF	MSM7X30_SURF		2679
> >  ea2478devkit		MACH_EA2478DEVKIT	EA2478DEVKIT		2683
> >  terastation_wxl		MACH_TERASTATION_WXL	TERASTATION_WXL		2697
> > -- 
> > 1.7.2.5
> > 
> > 
> > 




  reply	other threads:[~2011-12-06  7:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-01 11:04 [RFC][PATCH] ARM: kirkwood: Remove eSATA SheevaPlug board support Axel Lin
2011-12-01 11:04 ` Axel Lin
2011-12-01 11:57 ` Holland, John
2011-12-01 11:57   ` Holland, John
2011-12-03 11:39 ` Tixy
2011-12-03 11:39   ` Tixy
2011-12-03 18:00   ` Nicolas Pitre
2011-12-03 18:00     ` Nicolas Pitre
2011-12-06  7:07     ` Tixy [this message]
2011-12-06  7:07       ` Tixy
2011-12-06 19:45       ` Nicolas Pitre
2011-12-06 19:45         ` Nicolas Pitre
2011-12-06 20:22         ` Tixy
2011-12-06 21:18           ` Russell King - ARM Linux
2011-12-06  9:52     ` Patch 7193/1: Fix machine_is_xxx() naming for eSata SheevaPlug and QNAP TS-209 Tixy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1323155228.2237.10.camel@computer2 \
    --to=tixy@yxit.co.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.