From: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Julien Chauveau
<chauveau.julien-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org
Subject: Re: [PATCH 5/9] dt-bindings: add compatibles for rk3066/rk3188 power controllers
Date: Mon, 18 Sep 2017 08:29:54 +0200 [thread overview]
Message-ID: <13237503.R9C4DGAk4Y@phil> (raw)
In-Reply-To: <c2f4f70e-e5e7-9432-035d-fdf885eb53d0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Am Samstag, 16. September 2017, 23:04:48 CEST schrieb Julien Chauveau:
> Hello Heiko,
>
> There are a few copy/paste errors in the documentation.
>
>
> Le 15/09/2017 à 10:33, Heiko Stuebner a écrit :
> > Add the compatible values for the power-domain controllers found on
> > rk3066 and rk3188.
> >
> > Signed-off-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
> > ---
> > Documentation/devicetree/bindings/soc/rockchip/power_domain.txt | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt b/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt
> > index 301d2a9bc1b8..1c42c5b7ca6a 100644
> > --- a/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt
> > +++ b/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt
> > @@ -5,6 +5,8 @@ powered up/down by software based on different application scenes to save power.
> >
> > Required properties for power domain controller:
> > - compatible: Should be one of the following.
> > + "rockchip,rk3066-power-controller" - for RK3288 SoCs.
> > + "rockchip,rk3188-power-controller" - for RK3288 SoCs.
> These should be for RK3066 and RK3188.
> > "rockchip,rk3288-power-controller" - for RK3288 SoCs.
> > "rockchip,rk3328-power-controller" - for RK3328 SoCs.
> > "rockchip,rk3366-power-controller" - for RK3366 SoCs.
> > @@ -17,6 +19,8 @@ Required properties for power domain controller:
> >
> > Required properties for power domain sub nodes:
> > - reg: index of the power domain, should use macros in:
> > + "include/dt-bindings/power/rk3066-power.h" - for RK3288 type power domain.
> > + "include/dt-bindings/power/rk3188-power.h" - for RK3288 type power domain.
> Same here.
bah ... thanks for noticing. Will fix in a v2 shortly.
Thanks
Heiko
> > "include/dt-bindings/power/rk3288-power.h" - for RK3288 type power domain.
> > "include/dt-bindings/power/rk3328-power.h" - for RK3328 type power domain.
> > "include/dt-bindings/power/rk3366-power.h" - for RK3366 type power domain.
> Julien
>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/9] dt-bindings: add compatibles for rk3066/rk3188 power controllers
Date: Mon, 18 Sep 2017 08:29:54 +0200 [thread overview]
Message-ID: <13237503.R9C4DGAk4Y@phil> (raw)
In-Reply-To: <c2f4f70e-e5e7-9432-035d-fdf885eb53d0@gmail.com>
Am Samstag, 16. September 2017, 23:04:48 CEST schrieb Julien Chauveau:
> Hello Heiko,
>
> There are a few copy/paste errors in the documentation.
>
>
> Le 15/09/2017 ? 10:33, Heiko Stuebner a ?crit :
> > Add the compatible values for the power-domain controllers found on
> > rk3066 and rk3188.
> >
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > ---
> > Documentation/devicetree/bindings/soc/rockchip/power_domain.txt | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt b/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt
> > index 301d2a9bc1b8..1c42c5b7ca6a 100644
> > --- a/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt
> > +++ b/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt
> > @@ -5,6 +5,8 @@ powered up/down by software based on different application scenes to save power.
> >
> > Required properties for power domain controller:
> > - compatible: Should be one of the following.
> > + "rockchip,rk3066-power-controller" - for RK3288 SoCs.
> > + "rockchip,rk3188-power-controller" - for RK3288 SoCs.
> These should be for RK3066 and RK3188.
> > "rockchip,rk3288-power-controller" - for RK3288 SoCs.
> > "rockchip,rk3328-power-controller" - for RK3328 SoCs.
> > "rockchip,rk3366-power-controller" - for RK3366 SoCs.
> > @@ -17,6 +19,8 @@ Required properties for power domain controller:
> >
> > Required properties for power domain sub nodes:
> > - reg: index of the power domain, should use macros in:
> > + "include/dt-bindings/power/rk3066-power.h" - for RK3288 type power domain.
> > + "include/dt-bindings/power/rk3188-power.h" - for RK3288 type power domain.
> Same here.
bah ... thanks for noticing. Will fix in a v2 shortly.
Thanks
Heiko
> > "include/dt-bindings/power/rk3288-power.h" - for RK3288 type power domain.
> > "include/dt-bindings/power/rk3328-power.h" - for RK3328 type power domain.
> > "include/dt-bindings/power/rk3366-power.h" - for RK3366 type power domain.
> Julien
>
>
next prev parent reply other threads:[~2017-09-18 6:29 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 8:33 [PATCH 0/9] ARM: rockchip: add power-domains for Cortex-A9 socs Heiko Stuebner
2017-09-15 8:33 ` Heiko Stuebner
[not found] ` <20170915083357.11296-1-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2017-09-15 8:33 ` [PATCH 1/9] clk: rockchip: add more rk3188 graphics clock ids Heiko Stuebner
2017-09-15 8:33 ` Heiko Stuebner
[not found] ` <20170915083357.11296-2-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2017-10-14 19:30 ` Heiko Stuebner
2017-10-14 19:30 ` Heiko Stuebner
2017-09-15 8:33 ` [PATCH 2/9] clk: rockchip: use new cif/vdpu clock ids on rk3188 Heiko Stuebner
2017-09-15 8:33 ` Heiko Stuebner
[not found] ` <20170915083357.11296-3-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2017-10-14 21:03 ` Heiko Stuebner
2017-10-14 21:03 ` Heiko Stuebner
2017-09-15 8:33 ` [PATCH 3/9] dt-bindings: add power-domain header for RK3188 SoCs Heiko Stuebner
2017-09-15 8:33 ` Heiko Stuebner
2017-09-15 8:33 ` [PATCH 4/9] dt-bindings: add power-domain header for RK3066 SoCs Heiko Stuebner
2017-09-15 8:33 ` Heiko Stuebner
2017-09-15 8:33 ` [PATCH 5/9] dt-bindings: add compatibles for rk3066/rk3188 power controllers Heiko Stuebner
2017-09-15 8:33 ` Heiko Stuebner
[not found] ` <20170915083357.11296-6-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2017-09-16 21:04 ` Julien Chauveau
2017-09-16 21:04 ` Julien Chauveau
[not found] ` <c2f4f70e-e5e7-9432-035d-fdf885eb53d0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-09-18 6:29 ` Heiko Stuebner [this message]
2017-09-18 6:29 ` Heiko Stuebner
2017-09-15 8:33 ` [PATCH 6/9] soc: rockchip: power-domain: add rk3188 powerdomains Heiko Stuebner
2017-09-15 8:33 ` Heiko Stuebner
2017-09-15 8:33 ` [PATCH 7/9] soc: rockchip: power-domain: add rk3066 powerdomains Heiko Stuebner
2017-09-15 8:33 ` Heiko Stuebner
2017-09-15 8:33 ` [PATCH 8/9] ARM: dts: rockchip: add qos nodes found on rk3066 and rk3188 Heiko Stuebner
2017-09-15 8:33 ` Heiko Stuebner
2017-09-15 8:33 ` [PATCH 9/9] ARM: dts: rockchip: add rk3066/rk3188 power-domains Heiko Stuebner
2017-09-15 8:33 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13237503.R9C4DGAk4Y@phil \
--to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
--cc=chauveau.julien-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.