From: Peter Zijlstra <peterz@infradead.org>
To: Dmitry Torokhov <dtor@vmware.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
pv-drivers@vmware.com, Andrei Warkentin <andreiw@vmware.com>,
stable@kernel.org
Subject: Re: [PATCH] include/log2.h: Fix rounddown_pow_of_two(1)
Date: Tue, 13 Dec 2011 21:05:36 +0100 [thread overview]
Message-ID: <1323806736.28489.0.camel@twins> (raw)
In-Reply-To: <1323806421.9082.53.camel@twins>
On Tue, 2011-12-13 at 21:00 +0100, Peter Zijlstra wrote:
> On Mon, 2011-12-12 at 10:02 -0800, Dmitry Torokhov wrote:
> > 1 is a power of two, therefore rounddown_pow_of_two(1) should return 1.
>
> x^0 = 1
> x^1 = x
>
> Seems to me 0 was the right answer, no?
n/m head-up-arse, missed that this wasn't actually a log variant.
next prev parent reply other threads:[~2011-12-13 20:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 18:02 [PATCH] include/log2.h: Fix rounddown_pow_of_two(1) Dmitry Torokhov
2011-12-12 23:50 ` Linus Torvalds
2011-12-13 6:01 ` Dmitry Torokhov
2011-12-13 20:00 ` Peter Zijlstra
2011-12-13 20:05 ` Peter Zijlstra [this message]
2011-12-13 20:06 ` [Pv-drivers] " Bhavesh Davda
2011-12-13 20:07 ` Peter Zijlstra
-- strict thread matches above, loose matches on Subject: below --
2011-11-16 19:56 Andrei Warkentin
2011-11-16 22:51 ` Rolf Eike Beer
2011-11-17 23:05 ` Andrew Morton
2011-11-18 18:46 ` Andrei Warkentin
2011-11-19 9:26 ` Marco Stornelli
2011-11-22 23:34 ` Guennadi Liakhovetski
2011-11-08 19:08 Andrei Warkentin
2011-11-08 19:57 ` Jesper Juhl
2011-11-14 21:17 ` Andrei Warkentin
2011-11-14 23:27 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323806736.28489.0.camel@twins \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=andreiw@vmware.com \
--cc=dtor@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.