From: Peter Zijlstra <peterz@infradead.org>
To: Bhavesh Davda <bhavesh@vmware.com>
Cc: Dmitry Torokhov <dtor@vmware.com>,
Andrei Warkentin <awarkentin@vmware.com>,
"pv-drivers@vmware.com" <pv-drivers@vmware.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
"stable@kernel.org" <stable@kernel.org>
Subject: RE: [Pv-drivers] [PATCH] include/log2.h: Fix rounddown_pow_of_two(1)
Date: Tue, 13 Dec 2011 21:07:12 +0100 [thread overview]
Message-ID: <1323806832.28489.1.camel@twins> (raw)
In-Reply-To: <B07832953588294D802727FF264E276A13EC9D4B22@exch-mbx-112.vmware.com>
On Tue, 2011-12-13 at 12:06 -0800, Bhavesh Davda wrote:
> > On Mon, 2011-12-12 at 10:02 -0800, Dmitry Torokhov wrote:
> > > 1 is a power of two, therefore rounddown_pow_of_two(1) should return 1.
> >
> > x^0 = 1
> > x^1 = x
> >
> > Seems to me 0 was the right answer, no?
>
> Eh? The answer should be the power-of-two (1), not the exponent (0).
Yeah, just noticed that, see my other reply.
prev parent reply other threads:[~2011-12-13 20:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 18:02 [PATCH] include/log2.h: Fix rounddown_pow_of_two(1) Dmitry Torokhov
2011-12-12 23:50 ` Linus Torvalds
2011-12-13 6:01 ` Dmitry Torokhov
2011-12-13 20:00 ` Peter Zijlstra
2011-12-13 20:05 ` Peter Zijlstra
2011-12-13 20:06 ` [Pv-drivers] " Bhavesh Davda
2011-12-13 20:07 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323806832.28489.1.camel@twins \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=awarkentin@vmware.com \
--cc=bhavesh@vmware.com \
--cc=dtor@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.