All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: Matt Evans <matt@ozlabs.org>,
	kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, penberg@kernel.org,
	asias.hejun@gmail.com, gorcunov@gmail.com,
	Alexander Graf <agraf@suse.de>
Subject: Re: [PATCH V2 0/2] kvm tools: PPC64 basic support
Date: Wed, 14 Dec 2011 09:35:50 +0000	[thread overview]
Message-ID: <1323855350.21839.3.camel@pasglop> (raw)
In-Reply-To: <1323844555.3992.13.camel@lappy>

On Wed, 2011-12-14 at 08:35 +0200, Sasha Levin wrote:
> 
> In that case, KVM_CAP_IOEVENTFD is simply not set, so we're better off
> checking the cap dynamically instead of having it defined statically
> in the makefile.
> 
> I'll send a short patch that does that.

Indeed, and in general, even if it was set, a failure of the ioctl could
be handled gracefully by switching to not using it from the generic code
without an arch override.

Cheers,
Ben.



WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: Matt Evans <matt@ozlabs.org>,
	kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, penberg@kernel.org,
	asias.hejun@gmail.com, gorcunov@gmail.com,
	Alexander Graf <agraf@suse.de>
Subject: Re: [PATCH V2 0/2] kvm tools: PPC64 basic support
Date: Wed, 14 Dec 2011 20:35:50 +1100	[thread overview]
Message-ID: <1323855350.21839.3.camel@pasglop> (raw)
In-Reply-To: <1323844555.3992.13.camel@lappy>

On Wed, 2011-12-14 at 08:35 +0200, Sasha Levin wrote:
> 
> In that case, KVM_CAP_IOEVENTFD is simply not set, so we're better off
> checking the cap dynamically instead of having it defined statically
> in the makefile.
> 
> I'll send a short patch that does that.

Indeed, and in general, even if it was set, a failure of the ioctl could
be handled gracefully by switching to not using it from the generic code
without an arch override.

Cheers,
Ben.



  reply	other threads:[~2011-12-14  9:35 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-13  7:00 [PATCH V2 0/2] kvm tools: PPC64 basic support Matt Evans
2011-12-13  7:00 ` Matt Evans
2011-12-13  7:00 ` [PATCH V2 1/2] kvm tools: Add initial SPAPR PPC64 architecture support Matt Evans
2011-12-13  7:00   ` Matt Evans
2011-12-13  7:44   ` Pekka Enberg
2011-12-13  7:44     ` Pekka Enberg
2011-12-14  9:38     ` [PATCH V2 1/2] kvm tools: Add initial SPAPR PPC64 architecture Benjamin Herrenschmidt
2011-12-14  9:38       ` [PATCH V2 1/2] kvm tools: Add initial SPAPR PPC64 architecture support Benjamin Herrenschmidt
2011-12-14 10:30       ` Pekka Enberg
2011-12-14 10:30         ` Pekka Enberg
2011-12-14 10:41         ` [PATCH V2 1/2] kvm tools: Add initial SPAPR PPC64 architecture Benjamin Herrenschmidt
2011-12-14 10:41           ` [PATCH V2 1/2] kvm tools: Add initial SPAPR PPC64 architecture support Benjamin Herrenschmidt
     [not found]           ` <521B67B5-FA19-479A-A1DF-14A0E65C30AF@suse.de>
2011-12-14 11:31             ` [PATCH V2 1/2] kvm tools: Add initial SPAPR PPC64 architecture Pekka Enberg
2011-12-14 11:31               ` [PATCH V2 1/2] kvm tools: Add initial SPAPR PPC64 architecture support Pekka Enberg
2011-12-14 13:36             ` [PATCH V2 1/2] kvm tools: Add initial SPAPR PPC64 architecture Asias He
2011-12-14 13:36               ` [PATCH V2 1/2] kvm tools: Add initial SPAPR PPC64 architecture support Asias He
2011-12-13  8:23   ` Alexander Graf
2011-12-13  8:23     ` Alexander Graf
2011-12-15  1:27     ` [PATCH V2 1/2] kvm tools: Add initial SPAPR PPC64 architecture Matt Evans
2011-12-15  1:27       ` [PATCH V2 1/2] kvm tools: Add initial SPAPR PPC64 architecture support Matt Evans
2011-12-15  1:37       ` Alexander Graf
2011-12-15  1:37         ` Alexander Graf
2011-12-15  2:20         ` [PATCH V2 1/2] kvm tools: Add initial SPAPR PPC64 architecture Matt Evans
2011-12-15  2:20           ` [PATCH V2 1/2] kvm tools: Add initial SPAPR PPC64 architecture support Matt Evans
2011-12-13 17:43   ` Pekka Enberg
2011-12-13 17:43     ` Pekka Enberg
2011-12-13 21:41     ` Matt Evans
2011-12-13 21:41       ` Matt Evans
2011-12-13  7:00 ` [PATCH V2 2/2] kvm tools: Make virtio-pci's ioeventfd__add_event() fall back gracefully if ioeventfd Matt Evans
2011-12-13  7:00   ` [PATCH V2 2/2] kvm tools: Make virtio-pci's ioeventfd__add_event() fall back gracefully if ioeventfds unavailable Matt Evans
2011-12-13  8:25 ` [PATCH V2 0/2] kvm tools: PPC64 basic support Sasha Levin
2011-12-13 10:23   ` Sasha Levin
2011-12-14  0:34   ` Matt Evans
2011-12-14  0:34     ` Matt Evans
2011-12-14  6:35     ` Sasha Levin
2011-12-14  6:35       ` Sasha Levin
2011-12-14  9:35       ` Benjamin Herrenschmidt [this message]
2011-12-14  9:35         ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1323855350.21839.3.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=agraf@suse.de \
    --cc=asias.hejun@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=levinsasha928@gmail.com \
    --cc=matt@ozlabs.org \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.