From: Johannes Berg <johannes@sipsolutions.net>
To: Corentin Chary <corentin.chary@gmail.com>
Cc: Keng-Yu Lin <kengyu@canonical.com>,
Matthew Garrett <mjg@redhat.com>,
acpi4asus-user@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
Richard Purdie <rpurdie@rpsys.net>
Subject: Re: [PATCH] asus-wmi: explicitly set the wireless LED
Date: Thu, 15 Dec 2011 09:22:20 +0100 [thread overview]
Message-ID: <1323937340.3337.3.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <CAHR064iBtSTv79BhXt9_mMWugD4U_xLCM4i1wE7PLnZM8pL57g@mail.gmail.com> (sfid-20111215_080747_060859_05239F9D)
On Thu, 2011-12-15 at 08:07 +0100, Corentin Chary wrote:
> Anyway, you should use a led trigger for that, ideally the rfkill%d
> led trigger, but for that you need the rfkill idx, which is not
> exported, so you may need a new rfkill_idx() function. CCing rfkill
> and led guys, they may have a better advice on that.
Since you wouldn't want to build the string yourself, you'd probably
want a new rfkill_ledtrigname() function like this:
static const char *rfkill_ledtrigname(struct rfkill *rfkill)
{
#ifdef CONFIG_RFKILL_LEDS
return rfkill->ledtrigname;
#endif
return NULL;
}
which you use to assign the LED class device's default trigger.
johannes
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
To: Corentin Chary <corentin.chary-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Richard,
Keng-Yu Lin <kengyu-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
acpi4asus-user-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Purdie <rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org>,
Matthew Garrett <mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] asus-wmi: explicitly set the wireless LED
Date: Thu, 15 Dec 2011 09:22:20 +0100 [thread overview]
Message-ID: <1323937340.3337.3.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <CAHR064iBtSTv79BhXt9_mMWugD4U_xLCM4i1wE7PLnZM8pL57g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> (sfid-20111215_080747_060859_05239F9D)
On Thu, 2011-12-15 at 08:07 +0100, Corentin Chary wrote:
> Anyway, you should use a led trigger for that, ideally the rfkill%d
> led trigger, but for that you need the rfkill idx, which is not
> exported, so you may need a new rfkill_idx() function. CCing rfkill
> and led guys, they may have a better advice on that.
Since you wouldn't want to build the string yourself, you'd probably
want a new rfkill_ledtrigname() function like this:
static const char *rfkill_ledtrigname(struct rfkill *rfkill)
{
#ifdef CONFIG_RFKILL_LEDS
return rfkill->ledtrigname;
#endif
return NULL;
}
which you use to assign the LED class device's default trigger.
johannes
------------------------------------------------------------------------------
10 Tips for Better Server Consolidation
Server virtualization is being driven by many needs.
But none more important than the need to reduce IT complexity
while improving strategic productivity. Learn More!
http://www.accelacomm.com/jaw/sdnl/114/51507609/
next prev parent reply other threads:[~2011-12-15 8:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-07 8:02 [PATCH] asus-wmi: explicitly set the wireless LED Keng-Yu Lin
2011-12-15 7:07 ` Corentin Chary
2011-12-15 7:07 ` Corentin Chary
2011-12-15 8:22 ` Johannes Berg [this message]
2011-12-15 8:22 ` Johannes Berg
2011-12-15 8:25 ` Corentin Chary
2011-12-15 8:26 ` Johannes Berg
2011-12-15 8:26 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323937340.3337.3.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=corentin.chary@gmail.com \
--cc=kengyu@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.