All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alejandro T." <atafalla@dnyon.com>
To: Mark Brown <broonie@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	~postmarketos/upstreaming@lists.sr.ht,
	Mark Rutland <mark.rutland@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64/sysreg: Fix typo in Enum element regex
Date: Fri, 10 Jun 2022 14:50:18 +0200	[thread overview]
Message-ID: <13240249.uLZWGnKmhe@alexbook> (raw)
In-Reply-To: <YqMo1gGVgWQDBQjJ@sirena.org.uk>

On viernes, 10 de junio de 2022 13:19:50 (CEST) Mark Brown wrote:
> On Fri, Jun 10, 2022 at 10:15:04AM +0100, Catalin Marinas wrote:
> > On Thu, Jun 09, 2022 at 10:42:18PM +0200, Alejandro Tafalla wrote:
> > > In the awk script, there was a typo with the comparison operator when
> > > checking if the matched pattern is inside an Enum block.
> > > This prevented the generation of the whole sysreg-defs.h header.
> > > 
> > > -/0b[01]+/ && block = "Enum" {
> > > +/0b[01]+/ && block == "Enum" {
> > 
> > This makes sense but I'm surprised that we haven't noticed it until now
> > (maybe some awk versions treat it as a relational operator).
> 
> What Catlain said - if we weren't generating the full header contents
> I'd expect things to fail to build normally, but it's entirely possible
> this is just happening to work with some implementations and the patch
> is clearly correct.
> 
> Reviewed-by: Mark Brown <broonie@kernel.org>

Hi Mark, thanks for your review. 

Indeed, I'm building the kernel in Alpine, which uses Busybox instead of gawk.




_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: "Alejandro T." <atafalla@dnyon.com>
To: Mark Brown <broonie@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	~postmarketos/upstreaming@lists.sr.ht,
	Mark Rutland <mark.rutland@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64/sysreg: Fix typo in Enum element regex
Date: Fri, 10 Jun 2022 14:50:18 +0200	[thread overview]
Message-ID: <13240249.uLZWGnKmhe@alexbook> (raw)
In-Reply-To: <YqMo1gGVgWQDBQjJ@sirena.org.uk>

On viernes, 10 de junio de 2022 13:19:50 (CEST) Mark Brown wrote:
> On Fri, Jun 10, 2022 at 10:15:04AM +0100, Catalin Marinas wrote:
> > On Thu, Jun 09, 2022 at 10:42:18PM +0200, Alejandro Tafalla wrote:
> > > In the awk script, there was a typo with the comparison operator when
> > > checking if the matched pattern is inside an Enum block.
> > > This prevented the generation of the whole sysreg-defs.h header.
> > > 
> > > -/0b[01]+/ && block = "Enum" {
> > > +/0b[01]+/ && block == "Enum" {
> > 
> > This makes sense but I'm surprised that we haven't noticed it until now
> > (maybe some awk versions treat it as a relational operator).
> 
> What Catlain said - if we weren't generating the full header contents
> I'd expect things to fail to build normally, but it's entirely possible
> this is just happening to work with some implementations and the patch
> is clearly correct.
> 
> Reviewed-by: Mark Brown <broonie@kernel.org>

Hi Mark, thanks for your review. 

Indeed, I'm building the kernel in Alpine, which uses Busybox instead of gawk.




  reply	other threads:[~2022-06-10 12:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-09 20:42 [PATCH] arm64/sysreg: Fix typo in Enum element regex Alejandro Tafalla
2022-06-09 20:42 ` Alejandro Tafalla
2022-06-10  9:15 ` Catalin Marinas
2022-06-10  9:15   ` Catalin Marinas
2022-06-10 11:19   ` Mark Brown
2022-06-10 11:19     ` Mark Brown
2022-06-10 12:50     ` Alejandro T. [this message]
2022-06-10 12:50       ` Alejandro T.
2022-06-10 16:35 ` Catalin Marinas
2022-06-10 16:35   ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13240249.uLZWGnKmhe@alexbook \
    --to=atafalla@dnyon.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=will@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.