[PATCH] lockdep: do not disable on OOT taint

[PATCH] lockdep: do not disable on OOT taint

[Johannes Berg]

From: Johannes Berg <johannes.berg@intel.com>

There's no reason to disable lockdep due to
out-of-tree taint since you can just ignore
lockdep reports with OOT taint if you like
but for people who develop out of tree it's
still useful to have lockdep available.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
 kernel/panic.c |   12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

--- a/kernel/panic.c	2011-12-16 15:20:38.000000000 +0100
+++ b/kernel/panic.c	2011-12-16 15:51:37.000000000 +0100
@@ -240,8 +240,16 @@ void add_taint(unsigned flag)
 	 * Also we want to keep up lockdep for staging development and
 	 * post-warning case.
 	 */
-	if (flag != TAINT_CRAP && flag != TAINT_WARN && __debug_locks_off())
-		printk(KERN_WARNING "Disabling lock debugging due to kernel taint\n");
+	switch (flag) {
+	case TAINT_CRAP:
+	case TAINT_WARN:
+	case TAINT_OOT_MODULE:
+		break;
+	default:
+		if (__debug_locks_off())
+			printk(KERN_WARNING
+			       "Disabling lock debugging due to kernel taint\n");
+	}
 
 	set_bit(flag, &tainted_mask);
 }

Re: [PATCH] lockdep: do not disable on OOT taint

[Johannes Berg]

On Fri, 2011-12-16 at 15:57 +0100, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
> 
> There's no reason to disable lockdep due to
> out-of-tree taint since you can just ignore
> lockdep reports with OOT taint if you like
> but for people who develop out of tree it's
> still useful to have lockdep available.

Never mind. It was just pointed out to me that this was already done:

https://git.kernel.org/?p=linux/kernel/git/tip/tip.git;a=commitdiff;h=9ec84acee1e221d99dc33237bff5e82839d10cc0;hp=81140acc66322dcde8346dabdf1ab4c229fce8d4

Sorry!

johannes