From: Fabio Estevam <festevam@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v6 2/4] mx28: Allow to set MAC address for the two FECs
Date: Tue, 20 Dec 2011 11:53:30 -0200 [thread overview]
Message-ID: <1324389212-9208-2-git-send-email-festevam@gmail.com> (raw)
In-Reply-To: <1324389212-9208-1-git-send-email-festevam@gmail.com>
MX28 has two built-in FECs (Fast Ethernet Controller).
OCOTP register can be used to only store 4 bytes of MAC addresses.
In order to workaround this limitation, let the MAC address of FEC1 be
the FEC0 address plus one.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v5:
No changes. Newly introduced on this series
arch/arm/cpu/arm926ejs/mx28/mx28.c | 8 ++++++--
drivers/net/fec_mxc.c | 16 ++++++++++++++++
drivers/net/fec_mxc.h | 1 +
3 files changed, 23 insertions(+), 2 deletions(-)
diff --git a/arch/arm/cpu/arm926ejs/mx28/mx28.c b/arch/arm/cpu/arm926ejs/mx28/mx28.c
index a25814e..79b4001 100644
--- a/arch/arm/cpu/arm926ejs/mx28/mx28.c
+++ b/arch/arm/cpu/arm926ejs/mx28/mx28.c
@@ -227,7 +227,7 @@ void set_mac_vendor(char *mac)
#define MXS_OCOTP_MAX_TIMEOUT 1000000
-void imx_get_mac_from_fuse(char *mac)
+void mx28_get_mac_from_fuse(int dev_id, char *mac)
{
struct mx28_ocotp_regs *ocotp_regs =
(struct mx28_ocotp_regs *)MXS_OCOTP_BASE;
@@ -249,10 +249,14 @@ void imx_get_mac_from_fuse(char *mac)
mac[3] = (data >> 16) & 0xff;
mac[4] = (data >> 8) & 0xff;
mac[5] = data & 0xff;
+ /* Assume that FEC1 MAC address is MAC0 + 1 */
+ if (dev_id == 1)
+ mac[5]+= 1;
+
set_mac_vendor(mac);
}
#else
-void imx_get_mac_from_fuse(char *mac)
+void mx28_get_mac_from_fuse(int dev_id, char *mac)
{
memset(mac, 0, 6);
}
diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
index b05a4c0..a6bf597 100644
--- a/drivers/net/fec_mxc.c
+++ b/drivers/net/fec_mxc.c
@@ -345,11 +345,20 @@ static void fec_rbd_clean(int last, struct fec_bd *pRbd)
writew(0, &pRbd->data_length);
}
+#ifndef CONFIG_MX28
static int fec_get_hwaddr(struct eth_device *dev, unsigned char *mac)
{
imx_get_mac_from_fuse(mac);
return !is_valid_ether_addr(mac);
}
+#else
+static int mx28_fec_get_hwaddr(struct eth_device *dev, int dev_id,
+ unsigned char *mac)
+{
+ mx28_get_mac_from_fuse(dev_id, mac);
+ return !is_valid_ether_addr(mac);
+}
+#endif
static int fec_set_hwaddr(struct eth_device *dev)
{
@@ -812,10 +821,17 @@ static int fec_probe(bd_t *bd, int dev_id, int phy_id, uint32_t base_addr)
eth_register(edev);
+#ifndef CONFIG_MX28
if (fec_get_hwaddr(edev, ethaddr) == 0) {
debug("got MAC address from fuse: %pM\n", ethaddr);
memcpy(edev->enetaddr, ethaddr, 6);
}
+#else
+ if (mx28_fec_get_hwaddr(edev, dev_id, ethaddr) == 0) {
+ debug("got MAC%d address from fuse: %pM\n", dev_id, ethaddr);
+ memcpy(edev->enetaddr, ethaddr, 6);
+ }
+#endif
return ret;
diff --git a/drivers/net/fec_mxc.h b/drivers/net/fec_mxc.h
index 8b26645..e2cfe4a 100644
--- a/drivers/net/fec_mxc.h
+++ b/drivers/net/fec_mxc.h
@@ -33,6 +33,7 @@
#define __FEC_MXC_H
void imx_get_mac_from_fuse(unsigned char *mac);
+void mx28_get_mac_from_fuse(int dev_id, unsigned char *mac);
/**
* Layout description of the FEC
--
1.7.1
next prev parent reply other threads:[~2011-12-20 13:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-20 13:53 [U-Boot] [PATCH v6 1/4] mx28: Let imx_get_mac_from_fuse be common for mx28 Fabio Estevam
2011-12-20 13:53 ` Fabio Estevam [this message]
2011-12-20 13:57 ` [U-Boot] [PATCH v6 2/4] mx28: Allow to set MAC address for the two FECs Marek Vasut
2011-12-20 14:39 ` Stefano Babic
2011-12-20 13:53 ` [U-Boot] [PATCH v6 3/4] mx28: Let dram_init be common for mx28 Fabio Estevam
2011-12-20 13:57 ` Marek Vasut
2011-12-20 13:53 ` [U-Boot] [PATCH v6 4/4] mx28evk: Add initial support for MX28EVK board Fabio Estevam
2011-12-20 13:58 ` Marek Vasut
2011-12-28 12:20 ` Fabio Estevam
2011-12-28 12:36 ` Stefano Babic
2011-12-28 12:46 ` Fabio Estevam
2011-12-28 13:04 ` Fabio Estevam
2011-12-28 13:12 ` Stefano Babic
2011-12-28 12:37 ` Stefano Babic
2011-12-20 13:55 ` [U-Boot] [PATCH v6 1/4] mx28: Let imx_get_mac_from_fuse be common for mx28 Marek Vasut
2011-12-20 14:43 ` Veli-Pekka Peltola
2011-12-20 14:45 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324389212-9208-2-git-send-email-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.