Re: [PATCH] sedf: remove useless tracing printk and harmonize comments style.

[Dario Faggioli <raistlin@linux.it>]

[-- Attachment #1.1: Type: text/plain, Size: 1665 bytes --]

On Wed, 2011-12-21 at 12:21 +0000, George Dunlap wrote:
> RE removing the prinks, and most of the comment changes, ACK.
> 
Ok, that's what counts most. :-)

> However, I think the typical comment style is that you should either
> do things this way:
> 
> /* A one-line comment, start and end in one line */
> 
> Or this way:
> /*
>  * A multi-line comment,
>  * Where the opening and closing each have their own line.
>  */
> 
Which is my favorite...

> Or,
> /* If you have a short comment that can't fit on
>  * one line, put it on two, but with out any extra lines. */
> 
> But you seem to be replacing all multi-line comments with this:
> 
> /* The first line having the open-comment at the benning,
>  * But the close-comment having its own line.
>  */
> 
It looks weird to me too, but I'm sure I've seen it in a couple of
source files in xen (and it looked weird at that time too! :-P).
Moreover, it was like that on many multiline comments in sched_sedf.c,
so I just changed the one with an even weirder one to it.

> I've never seen that before, and it looks a bit weird. :-)
> 
100% Agree. :-)

> I prefer the first two, with judicious use of the third when appropriate.
> 
I can't be more happy to hear that, I'll go for the first, the one with
both wings. :-D

Thanks,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-------------------------------------------------------------------
Dario Faggioli, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
PhD Candidate, ReTiS Lab, Scuola Superiore Sant'Anna, Pisa (Italy)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel