Re: [PATCH 6/9] distro: Factor out poky-common.inc from poky.conf

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Wed, 2011-12-21 at 09:02 -0800, Darren Hart wrote:
> 
> On 12/21/2011 08:47 AM, Darren Hart wrote:
> > 
> > 
> > On 12/21/2011 08:28 AM, Richard Purdie wrote:
> >> On Wed, 2011-12-21 at 01:02 -0800, Darren Hart wrote:
> >>> Prepare to add additional poky distro variants by factoring out
> >>> assignments common to all poky* distros into poky-common.inc. Things
> >>> like the naming schemes, mirrors, etc. are common, while dependencies
> >>> and other things impacting image generation should be distro specific.
> >>>
> >>> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
> >>
> >> Why doesn't something like:
> >>
> >> """
> >> $meta-yocto/conf/distro$ cat poky-lsb.conf 
> >> require conf/distro/poky.conf
> >>
> >> DISTRO = "poky-lsb"
> >> DISTROOVERRIDES = "poky:linuxstdbase"
> >> """
> >>
> >> work?
> >>
> >> Effectively the above takes poky but then customises it...
> > 
> > I seem to recall something about this being harder with tiny as it
> > removes things rather than just extending. But I can't put recall
> > exactly what the issue was (or if there was one). I shall try it this
> > way if you prefer this approach. I felt the .inc approach provided a
> > more explicit building block mechanism which seemed more intuitive and
> > less prone to accidental inclusion. But, I don't feel strongly one way
> > or the other.
> 
> Aha, now I remember. Consider things like the following, defined in
> poky.conf:
> 
> DISTRO_FEATURES_append = " largefile opengl"
> 
> This one, not so bad, I can easily override it.

Right, I'd expect you are totally overriding DISTRO_FEATURES anyway.

> PREFERRED_VERSION_linux-yocto ?= "2.6.37+git%"
> PREFERRED_VERSION_linux-yocto_qemux86 ?= "3.0%"
> PREFERRED_VERSION_linux-yocto_qemux86-64 ?= "3.0%"
> PREFERRED_VERSION_linux-yocto_qemuarm ?= "3.0%"
> PREFERRED_VERSION_linux-yocto_qemumips ?= "3.0%"
> PREFERRED_VERSION_linux-yocto_qemuppc ?= "3.0%"
> 
> 
> All the above I could override.... but I'd rather be able to use the
> default without having to override them. This pollutes my distro config
> space unnecessarily in my opinion.

Right now you need to override these things, in future I suspect you're
going to want to share them when tiny becomes compatible with the
default kernel. This is why I feel the line you've drawn over what to
put into the .inc is a little arbitrary and why its a bad idea.

> DISTRO_EXTRA_RRECOMMENDS += "kernel-module-af-packet"
> 
> Things like this are the kicker. I don't know of a way to remove just
> what poky.conf appended to a variable, and not wipe out the rest of the
> variable.

So can we just change poky.conf to do:

POKYDEFAULTRECOMMENDS = "kernel-module-af-packet
DISTRO_EXTRA_RRECOMMENDS += "${POKYDEFAULTRECOMMENDS}"

and then you can change POKYDEFAULTRECOMMENDS to ""?

Cheers,

Richard