* [PATCH] ALSA: asihpi - fix pcm dma pointer tracking
@ 2011-12-21 22:54 linux
2011-12-22 7:15 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: linux @ 2011-12-21 22:54 UTC (permalink / raw)
To: tiwai; +Cc: Eliot Blennerhassett, alsa-devel
From: Eliot Blennerhassett <eblennerhassett@audioscience.com>
Elapsed counter should only count data committed to snd_pcm_period_elapsed,
rather than all data available
Signed-off-by: Eliot Blennerhassett <eblennerhassett@audioscience.com>
---
sound/pci/asihpi/asihpi.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/pci/asihpi/asihpi.c b/sound/pci/asihpi/asihpi.c
index e9de799..322ddfe 100644
--- a/sound/pci/asihpi/asihpi.c
+++ b/sound/pci/asihpi/asihpi.c
@@ -888,8 +888,8 @@ static void snd_card_asihpi_timer_function(unsigned long data)
pd, xfer2));
}
}
- ds->pcm_buf_host_rw_ofs = ds->pcm_buf_host_rw_ofs + xfercount;
- ds->pcm_buf_elapsed_dma_ofs = pcm_buf_dma_ofs;
+ ds->pcm_buf_host_rw_ofs = += xfercount;
+ ds->pcm_buf_elapsed_dma_ofs += xfercount;
snd_pcm_period_elapsed(s);
}
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: asihpi - fix pcm dma pointer tracking
2011-12-21 22:54 [PATCH] ALSA: asihpi - fix pcm dma pointer tracking linux
@ 2011-12-22 7:15 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2011-12-22 7:15 UTC (permalink / raw)
To: linux; +Cc: Eliot Blennerhassett, alsa-devel
At Thu, 22 Dec 2011 11:54:02 +1300,
linux@audioscience.com wrote:
>
> From: Eliot Blennerhassett <eblennerhassett@audioscience.com>
>
> Elapsed counter should only count data committed to snd_pcm_period_elapsed,
> rather than all data available
>
> Signed-off-by: Eliot Blennerhassett <eblennerhassett@audioscience.com>
> ---
> sound/pci/asihpi/asihpi.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/pci/asihpi/asihpi.c b/sound/pci/asihpi/asihpi.c
> index e9de799..322ddfe 100644
> --- a/sound/pci/asihpi/asihpi.c
> +++ b/sound/pci/asihpi/asihpi.c
> @@ -888,8 +888,8 @@ static void snd_card_asihpi_timer_function(unsigned long data)
> pd, xfer2));
> }
> }
> - ds->pcm_buf_host_rw_ofs = ds->pcm_buf_host_rw_ofs + xfercount;
> - ds->pcm_buf_elapsed_dma_ofs = pcm_buf_dma_ofs;
> + ds->pcm_buf_host_rw_ofs = += xfercount;
A typo here. I applied the patch with the fix now.
thanks,
Takashi
> + ds->pcm_buf_elapsed_dma_ofs += xfercount;
> snd_pcm_period_elapsed(s);
> }
> }
> --
> 1.7.0.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-12-22 7:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-21 22:54 [PATCH] ALSA: asihpi - fix pcm dma pointer tracking linux
2011-12-22 7:15 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.